From 117b93a3fd2a2f20780c4e52a5ead72720229f08 Mon Sep 17 00:00:00 2001 From: fwqaaq Date: Mon, 15 May 2023 18:43:17 +0800 Subject: fix: add error handler when targetname is --- xmake/actions/create/main.lua | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xmake/actions/create/main.lua b/xmake/actions/create/main.lua index 560b3b457..cdfe1694e 100644 --- a/xmake/actions/create/main.lua +++ b/xmake/actions/create/main.lua @@ -31,6 +31,9 @@ end -- create project from template function _create_project(language, templateid, targetname) + if targetname == '.' then + raise("you should specific ${red}-P${reset} instead of using ${red}.${reset}") + end -- check the language assert(language, "no language!") -- cgit v1.3.1 From dcbdeb57a9573cf747fc7268c648c40b61b2f2cf Mon Sep 17 00:00:00 2001 From: fwqaaq Date: Mon, 15 May 2023 18:46:22 +0800 Subject: Apply suggestions from code review --- xmake/actions/create/main.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xmake/actions/create/main.lua b/xmake/actions/create/main.lua index cdfe1694e..aa33b2cda 100644 --- a/xmake/actions/create/main.lua +++ b/xmake/actions/create/main.lua @@ -32,7 +32,7 @@ end -- create project from template function _create_project(language, templateid, targetname) if targetname == '.' then - raise("you should specific ${red}-P${reset} instead of using ${red}.${reset}") + raise("you should specific ${red}-P${reset} instead of directly using ${red}.${reset}") end -- check the language -- cgit v1.3.1 From 4e768cef8bfada5097b9040a877400413adaef3e Mon Sep 17 00:00:00 2001 From: fwqaaq Date: Mon, 15 May 2023 18:47:29 +0800 Subject: Apply suggestions from code review --- xmake/actions/create/main.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xmake/actions/create/main.lua b/xmake/actions/create/main.lua index aa33b2cda..ff90e4602 100644 --- a/xmake/actions/create/main.lua +++ b/xmake/actions/create/main.lua @@ -32,7 +32,7 @@ end -- create project from template function _create_project(language, templateid, targetname) if targetname == '.' then - raise("you should specific ${red}-P${reset} instead of directly using ${red}.${reset}") + raise("you should specify ${red}-P${reset} instead of directly using ${red}.${reset}") end -- check the language -- cgit v1.3.1 From c75621554028dece1350e9ed004b8f324b4878c9 Mon Sep 17 00:00:00 2001 From: fwqaaq Date: Mon, 15 May 2023 23:07:32 +0800 Subject: update --- xmake/actions/create/main.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xmake/actions/create/main.lua b/xmake/actions/create/main.lua index ff90e4602..69aa52997 100644 --- a/xmake/actions/create/main.lua +++ b/xmake/actions/create/main.lua @@ -31,9 +31,9 @@ end -- create project from template function _create_project(language, templateid, targetname) - if targetname == '.' then - raise("you should specify ${red}-P${reset} instead of directly using ${red}.${reset}") - end + + -- check the targetname + assert(targetname ~= ".", "you should specify ${red}-P${reset} instead of directly using ${red}.${reset}") -- check the language assert(language, "no language!") -- cgit v1.3.1