From cffe3388442b419a39daed160c98a7ccff1432bb Mon Sep 17 00:00:00 2001 From: ruki Date: Sat, 23 Mar 2024 00:45:38 +0800 Subject: update comments --- xmake/modules/package/manager/system/find_package.lua | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xmake/modules/package/manager/system/find_package.lua b/xmake/modules/package/manager/system/find_package.lua index 2a7b4727c..0d0db8a18 100644 --- a/xmake/modules/package/manager/system/find_package.lua +++ b/xmake/modules/package/manager/system/find_package.lua @@ -66,8 +66,11 @@ function main(name, opt) end snippet_configs.links = snippet_configs.links or name - -- we need to check package toolchain first + -- We need to check package toolchain first -- https://github.com/xmake-io/xmake/issues/4596#issuecomment-2014528801 + -- + -- But if it depends on some toolchain packages, + -- then they can't be detected early in the fetch and we have to disable system.find_package if opt.package and not _check_package_toolchains(opt.package) then return end -- cgit v1.3.1