From f5c5b95be6882bfecb4485927dced531d76028f9 Mon Sep 17 00:00:00 2001 From: ruki Date: Sat, 27 Feb 2021 00:41:40 +0800 Subject: add some comments --- xmake/modules/package/tools/cmake.lua | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xmake/modules/package/tools/cmake.lua b/xmake/modules/package/tools/cmake.lua index 6b390e075..8b3b606fd 100644 --- a/xmake/modules/package/tools/cmake.lua +++ b/xmake/modules/package/tools/cmake.lua @@ -228,6 +228,8 @@ function _get_configs_for_windows(package, configs, opt) table.insert(configs, "x64") end end + -- we maybe need patch `cmake_policy(SET CMP0091 NEW)` to enable this argument for some packages + -- @see https://github.com/xmake-io/xmake-repo/pull/303 local vs_runtime = package:config("vs_runtime") if vs_runtime == "MT" then table.insert(configs, "-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded") -- cgit v1.3.1