From f74e4e078d63bd5a7ccf699729c9f4852a4f5e33 Mon Sep 17 00:00:00 2001 From: ruki Date: Thu, 22 Feb 2024 23:35:32 +0800 Subject: add some comments --- xmake/modules/package/tools/cmake.lua | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xmake/modules/package/tools/cmake.lua b/xmake/modules/package/tools/cmake.lua index 77520b6a3..f0786091c 100644 --- a/xmake/modules/package/tools/cmake.lua +++ b/xmake/modules/package/tools/cmake.lua @@ -96,6 +96,8 @@ function _get_msvc_runenvs(package) local envs = {} local curenvs = os.getenvs() for k, v in pairs(os.joinenvs(_get_msvc(package):runenvs())) do + -- fix case naming conflict for msbuild between the new msvc envs and current environment, if we are running xmake in vs prompt. + -- @see https://github.com/xmake-io/xmake/issues/4751 local ck_found for ck, cv in pairs(curenvs) do if k:lower() == ck:lower() and k ~= ck then -- cgit v1.3.1