From 25e1d8ace98008b51772abefe49c8e533c9e04b2 Mon Sep 17 00:00:00 2001 From: ruki Date: Wed, 11 Sep 2024 23:11:13 +0800 Subject: improve tools.cmake for wasm --- xmake/modules/package/tools/cmake.lua | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/xmake/modules/package/tools/cmake.lua b/xmake/modules/package/tools/cmake.lua index 91a5e0559..543d402e1 100644 --- a/xmake/modules/package/tools/cmake.lua +++ b/xmake/modules/package/tools/cmake.lua @@ -612,17 +612,13 @@ function _get_configs_for_wasm(package, configs, opt) end end - local envs = {} - local deps_installdir = {} - for _, dep in ipairs(package:librarydeps({private = true})) do - if not dep:is_system() then - table.insert(deps_installdir, dep:installdir()) - end - end - -- https://github.com/emscripten-core/emscripten/issues/13310 - envs.CMAKE_FIND_ROOT_PATH = path.joinenv(deps_installdir) - _get_configs_for_generic(package, configs, opt) - _insert_configs_from_envs(configs, envs, opt) + -- avoid find and add system include/library path + -- @see https://github.com/xmake-io/xmake/issues/2037 + -- https://github.com/xmake-io/xmake/issues/5577 + table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=BOTH") + table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=BOTH") + table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=BOTH") + table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER") end -- get configs for cross -- cgit v1.3.1 From 921793ce047d9ae3ec4ca429f0981c05c026c397 Mon Sep 17 00:00:00 2001 From: ruki Date: Wed, 11 Sep 2024 23:11:42 +0800 Subject: improve tools.cmake for wasm --- xmake/modules/package/tools/cmake.lua | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/xmake/modules/package/tools/cmake.lua b/xmake/modules/package/tools/cmake.lua index 543d402e1..f47f69482 100644 --- a/xmake/modules/package/tools/cmake.lua +++ b/xmake/modules/package/tools/cmake.lua @@ -593,6 +593,7 @@ end -- get configs for wasm function _get_configs_for_wasm(package, configs, opt) opt = opt or {} + local envs = {} local emsdk = find_emsdk() assert(emsdk and emsdk.emscripten, "emscripten not found!") local emscripten_cmakefile = find_file("Emscripten.cmake", path.join(emsdk.emscripten, "cmake/Modules/Platform")) @@ -613,12 +614,14 @@ function _get_configs_for_wasm(package, configs, opt) end -- avoid find and add system include/library path - -- @see https://github.com/xmake-io/xmake/issues/2037 - -- https://github.com/xmake-io/xmake/issues/5577 - table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=BOTH") - table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=BOTH") - table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=BOTH") - table.insert(configs, "-DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER") + -- @see https://github.com/xmake-io/xmake/issues/5577 + -- https://github.com/emscripten-core/emscripten/issues/13310 + envs.CMAKE_FIND_ROOT_PATH_MODE_PACKAGE = "BOTH" + envs.CMAKE_FIND_ROOT_PATH_MODE_LIBRARY = "BOTH" + envs.CMAKE_FIND_ROOT_PATH_MODE_INCLUDE = "BOTH" + envs.CMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "NEVER" + _get_configs_for_generic(package, configs, opt) + _insert_configs_from_envs(configs, envs, opt) end -- get configs for cross -- cgit v1.3.1