diff options
| author | Atish Patra <[email protected]> | 2019-01-18 13:35:47 -0800 |
|---|---|---|
| committer | Anup Patel <[email protected]> | 2019-01-22 10:03:49 +0530 |
| commit | 784a4657c0957e7f9561fd2d87930ba008643c1e (patch) | |
| tree | c8711726b76df9d32e82122870921f790c1c7c54 | |
| parent | 1ee745fe57c3ad9db64bb31564f21a4fab101f22 (diff) | |
lib: Move software interrupt enablement from firmware to lib
The secondary hart waits for an IPI signal from the boot hart to
executing boot code (hot boot). As a result, software generated
interrupts have to be enabled for secondary harts before waiting for
the boot hart boot completion IPI signal.
Enabling software generated interrupts (IPI) can be done independently
of the firmware code and moved to libsbi code so that the different
firmware do not have to implement this.
Signed-off-by: Atish Patra <[email protected]>
| -rw-r--r-- | firmware/fw_base.S | 4 | ||||
| -rw-r--r-- | lib/sbi_hart.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/firmware/fw_base.S b/firmware/fw_base.S index ad6371bb..5738f57e 100644 --- a/firmware/fw_base.S +++ b/firmware/fw_base.S @@ -125,10 +125,6 @@ _start_warm: csrw mie, zero csrw mip, zero - /* Set MSIE bit to receive IPI */ - li a2, MIP_MSIP - csrw mie, a2 - /* Preload per-HART details * s6 -> HART ID * s7 -> HART Count diff --git a/lib/sbi_hart.c b/lib/sbi_hart.c index e8a689ed..e12a5468 100644 --- a/lib/sbi_hart.c +++ b/lib/sbi_hart.c @@ -304,6 +304,10 @@ void sbi_hart_wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid) if ((sbi_platform_hart_count(plat) <= hartid) || (COLDBOOT_WAIT_BITMAP_SIZE <= hartid)) sbi_hart_hang(); + + /* Set MSIE bit to receive IPI */ + csr_set(mie, MIP_MSIP); + do { spin_lock(&coldboot_wait_bitmap_lock); coldboot_wait_bitmap |= (1UL << hartid); |