summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiang W <[email protected]>2023-07-10 00:02:29 +0800
committerAnup Patel <[email protected]>2023-07-12 10:02:27 +0530
commitcc89fa7b5481b3279f1628f71debf795d5618044 (patch)
tree8d2a24325e617e339c0d2ad613545cdfe481b741
parent3b6fcddcebf82bb58ac750a2ab4d6e22d7549ac9 (diff)
lib: sbi: Fix printc
Because *out needs to reserve a byte to hold '\0', no more characters should be added to the buffer when *out has one byte left, and the buffer size *out_len should not be modified. this patch prevents the correction of *out_len when *out_len is 1. Signed-off-by: Xiang W <[email protected]> Reviewed-by: Anup Patel <[email protected]>
-rw-r--r--lib/sbi/sbi_console.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
index adbe2e6b..6915148b 100644
--- a/lib/sbi/sbi_console.c
+++ b/lib/sbi/sbi_console.c
@@ -142,10 +142,9 @@ static void printc(char **out, u32 *out_len, char ch)
if (!out_len || *out_len > 1) {
*(*out)++ = ch;
**out = '\0';
+ if (out_len)
+ --(*out_len);
}
-
- if (out_len && *out_len > 0)
- --(*out_len);
}
static int prints(char **out, u32 *out_len, const char *string, int width,