diff options
| author | Heinrich Schuchardt <[email protected]> | 2023-09-29 23:53:55 +0200 |
|---|---|---|
| committer | Anup Patel <[email protected]> | 2023-10-06 17:29:09 +0530 |
| commit | d891caeae96397ba7a5ab01d6722996ea3a1dd16 (patch) | |
| tree | 010876c8c31dc44a704199e11997a9bb2fea6a57 /lib/utils | |
| parent | f831b93357dd5858ba0f610f1f21f7bc599decb1 (diff) | |
gpio/starfive: redundant readl() call
In starfive_gpio_direction_output() readl() is called twice to read the
gpio direction register. The result of the first read is discarded.
Remove the redundant read.
Fixes: 908be1b85c8f ("gpio/starfive: add gpio driver and support gpio reset")
Signed-off-by: Heinrich Schuchardt <[email protected]>
Reviewed-by: Anup Patel <[email protected]>
Diffstat (limited to 'lib/utils')
| -rw-r--r-- | lib/utils/gpio/fdt_gpio_starfive.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/utils/gpio/fdt_gpio_starfive.c b/lib/utils/gpio/fdt_gpio_starfive.c index f430b135..bd2a9f21 100644 --- a/lib/utils/gpio/fdt_gpio_starfive.c +++ b/lib/utils/gpio/fdt_gpio_starfive.c @@ -37,7 +37,6 @@ static int starfive_gpio_direction_output(struct gpio_pin *gp, int value) reg_addr = chip->addr + gp->offset; reg_addr &= ~(STARFIVE_GPIO_REG_SHIFT_MASK); - val = readl((void *)(reg_addr)); shift_bits = (gp->offset & STARFIVE_GPIO_REG_SHIFT_MASK) << STARFIVE_GPIO_SHIFT_BITS; bit_mask = STARFIVE_GPIO_MASK << shift_bits; |