summaryrefslogtreecommitdiff
path: root/include/rtthread.h
diff options
context:
space:
mode:
authorkenneth.liu <[email protected]>2025-02-20 20:25:30 +0800
committerMeco Man <[email protected]>2025-02-20 22:38:06 -0500
commita5b26bb588303f7b503156d634e05d21d873a245 (patch)
tree33cf96efc197bcbeaf66d815223caffd639bff5b /include/rtthread.h
parent2e332d34631651324f1f7518e943db66d46c3cdc (diff)
components: libc: fix array overflow in rt_object name assignment
[Problem Description] When assigning name to rt_object, strncpy() uses size equal to RT_NAME_MAX, which causes missing null-terminator and overflows into adjacent 'type' field. This corruption leads to unexpected system behavior. [Problem Analysis] The rt_object structure defines: | char name[RT_NAME_MAX] | -> buffer | rt_uint8_t type | -> adjacent field Original code calculates size as: size = end - first + 1; if (size > RT_NAME_MAX) size = RT_NAME_MAX; When size equals RT_NAME_MAX, strncpy() will copy exactly RT_NAME_MAX bytes without adding terminating '\0', causing two issues: 1. name buffer is not null-terminated 2. The implicit null-byte writes beyond name[] into type field [Solution] Change boundary check from: if (size > RT_NAME_MAX) size = RT_NAME_MAX; to: if (size >= RT_NAME_MAX) size = RT_NAME_MAX - 1; This ensures: 1. Always leaves space for null-terminator 2. Prevents overflow into type field 3. Maintains maximum valid name length (RT_NAME_MAX-1 + '\0') Signed-off-by: Liu Gui <[email protected]>
Diffstat (limited to 'include/rtthread.h')
0 files changed, 0 insertions, 0 deletions