diff options
| author | Frédéric Desbiens <[email protected]> | 2026-04-29 09:10:57 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2026-04-29 09:10:57 -0400 |
| commit | 33efad3fee3414aef0d99e416361226b8568fd26 (patch) | |
| tree | 75e01b7d63dee7e65219462753c5ce6e5ca5450e /common/src/tx_thread_stack_error_notify.c | |
| parent | d5c75fd38f1e7dfc15772f1b122d541fe8ee540c (diff) | |
Fixed race condition and message loss in Cortex-M ports (#523)
* Fixed race condition and message loss in Cortex-M GNU, AC6, and IAR ports (#516)
- Added compiler memory barriers to BASEPRI management functions in tx_port.h.
- Added architectural barriers (DSB/ISB) to scheduler return paths in tx_port.h and tx_thread_system_return.S to prevent fall-through before context switch.
- These changes address spurious thread resumption and lost messages, especially when TX_NOT_INTERRUPTABLE is enabled.
- These changes ensure that pending interrupts (specifically PendSV) are recognised before subsequent instructions are executed, following Kairalite's feedback and ARM architectural guidelines.
Assisted-by: Gemini (Gemini 2.0 Flash)
-----
* Added a comment in common/tx_queue_cleanup to document why the NI path omits revalidation guards
- In `TX_NOT_INTERRUPTABLE` mode, the caller keeps interrupts disabled across the entire cleanup call, so the race window that makes the guards necessary in the interruptable path cannot occur. Add a comment explaining this, and noting that all paths that resume a suspended thread clear tx_thread_suspend_cleanup before calling
_tx_thread_system_ni_resume, making double-cleanup impossible.
This prevents future false-positive suggestions (e.g. from AI tools) to add redundant checks to the NI path.
Relates to: eclipse-threadx/threadx#516
Co-authored-by: Copilot <[email protected]>
Diffstat (limited to 'common/src/tx_thread_stack_error_notify.c')
0 files changed, 0 insertions, 0 deletions
