summaryrefslogtreecommitdiff
path: root/.github/workflows
diff options
context:
space:
mode:
authorhathach <[email protected]>2026-06-02 00:24:05 +0700
committerhathach <[email protected]>2026-06-02 00:24:05 +0700
commit044cd06f87117afa541d8cc743fcc9ef2bdc8089 (patch)
treebfee68ede8f40a8425d1c925f37bea3a231e7b05 /.github/workflows
parent1ea04f7fe67bac927848e9dfd3ce2f607e7b93d7 (diff)
ci: address second codex/copilot review round
- claude.yml: drop the issues "assigned" trigger; its author_association gate keys on the issue author, not the assigner, so a maintainer assigning an outside contributor's issue would be wrongly skipped. - claude-code-review.yml: issues: read -> write so use_sticky_comment can create/update its PR comment via the issues API. - hil SKILL.md: make local/remote command blocks copy-pasteable (drop [-b BOARD_NAME] notation for concrete examples) and fix timeout (600000 ms is 10 min; use 1200000 ms for the stated 20 min). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Diffstat (limited to '.github/workflows')
-rw-r--r--.github/workflows/claude-code-review.yml2
-rw-r--r--.github/workflows/claude.yml5
2 files changed, 5 insertions, 2 deletions
diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml
index 6c8bbb03d..4a0e4639b 100644
--- a/.github/workflows/claude-code-review.yml
+++ b/.github/workflows/claude-code-review.yml
@@ -21,7 +21,7 @@ jobs:
permissions:
contents: read
pull-requests: write
- issues: read
+ issues: write # use_sticky_comment posts/updates a PR comment via the issues API
id-token: write
actions: read # Required for Claude to read CI results on PRs
diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml
index dedecd349..bf7a401e4 100644
--- a/.github/workflows/claude.yml
+++ b/.github/workflows/claude.yml
@@ -6,7 +6,10 @@ on:
pull_request_review_comment:
types: [created]
issues:
- types: [opened, assigned]
+ # only "opened" — an issue's author_association gates the summon below;
+ # "assigned" would gate on the issue author, not the assigner, so a
+ # maintainer assigning an outsider's issue would be wrongly skipped.
+ types: [opened]
pull_request_review:
types: [submitted]