summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorhathach <[email protected]>2020-04-22 00:25:08 +0700
committerhathach <[email protected]>2020-04-22 00:29:51 +0700
commit3b83813f017dfd08e19a7a3bc2dc575779b1eadd (patch)
treed0c132f50e40ef3b31f863d30e5bedf5946c982e
parentde43df2d97b83b59d74e3b34b81ef73719a1173d (diff)
clean up
-rw-r--r--.github/ISSUE_TEMPLATE/bug_report.md13
-rw-r--r--.github/ISSUE_TEMPLATE/feature_request.md7
-rw-r--r--.github/ISSUE_TEMPLATE/question.md2
-rw-r--r--README.md4
-rw-r--r--src/class/midi/midi_device.c5
5 files changed, 17 insertions, 14 deletions
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
index c4d2757d2..5c70569d0 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.md
+++ b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -7,17 +7,20 @@ assignees: ''
---
-**Set up (mandatory):**
-Provide details of your setup help us to reproduce the issue as quick as possible
+**Set up**
+[Mandatory] Provide details of your setup help us to reproduce the issue as quick as possible
- **PC OS** : Ubuntu 18.04 / Windows 10/ macOS 10.15
- **Board** : Feather nRF52840 Express
- **Firmware**: examples/device/cdc_msc
-**Bug Description**
-Describe what the bug is.
+**Describe the bug**
+A clear and concise description of what the bug is.
-**Reproduce**
+**To reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. See error
+
+**Log & screenshots**
+If applicable, add screenshots and TinyUSB's log to help explain your problem. To enable logging, add `LOG=2` to your make command if building with stock examples or set `CFG_TUSB_DEBUG=2` in your tusb_config.h. \ No newline at end of file
diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md
index cb211eeb4..f34ff49ed 100644
--- a/.github/ISSUE_TEMPLATE/feature_request.md
+++ b/.github/ISSUE_TEMPLATE/feature_request.md
@@ -7,5 +7,8 @@ assignees: ''
---
-**Feature Description**
-Describe your feature
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md
index 3a9fd205c..d12c9785d 100644
--- a/.github/ISSUE_TEMPLATE/question.md
+++ b/.github/ISSUE_TEMPLATE/question.md
@@ -7,4 +7,4 @@ assignees: ''
---
-**Question Description**
+**Describe what the question is**
diff --git a/README.md b/README.md
index a8a533fd4..a7551155d 100644
--- a/README.md
+++ b/README.md
@@ -73,10 +73,6 @@ TinyUSB is completely thread-safe by pushing all ISR events into a central queue
- **FreeRTOS**
- **Mynewt** Due to the newt package build system, Mynewt examples are better to be on its [own repo](https://github.com/hathach/mynewt-tinyusb-example)
-## Compiler & IDE
-
-The stack is developed with GCC compiler and should be compilable with others. The `examples` folder provides Makefile and Segger Embedded Studio build support. [Here are example build instructions](examples/readme.md).
-
## Getting Started
[Here are the details for getting started](docs/getting_started.md) with the stack.
diff --git a/src/class/midi/midi_device.c b/src/class/midi/midi_device.c
index 589d0123f..f8db63b73 100644
--- a/src/class/midi/midi_device.c
+++ b/src/class/midi/midi_device.c
@@ -88,13 +88,14 @@ bool tud_midi_n_mounted (uint8_t itf)
static void _prep_out_transaction (midid_interface_t* p_midi)
{
// skip if previous transfer not complete
- if ( usbd_edpt_busy(TUD_OPT_RHPORT, p_midi->ep_out) )
- return;
+ if ( usbd_edpt_busy(TUD_OPT_RHPORT, p_midi->ep_out) ) return;
// Prepare for incoming data but only allow what we can store in the ring buffer.
uint16_t max_read = tu_fifo_remaining(&p_midi->rx_ff);
if ( max_read >= CFG_TUD_MIDI_EPSIZE )
+ {
usbd_edpt_xfer(TUD_OPT_RHPORT, p_midi->ep_out, p_midi->epout_buf, CFG_TUD_MIDI_EPSIZE);
+ }
}
//--------------------------------------------------------------------+