diff options
| author | Jerzy Kasenberg <[email protected]> | 2020-05-06 14:25:46 +0200 |
|---|---|---|
| committer | Jerzy Kasenberg <[email protected]> | 2020-05-06 14:25:46 +0200 |
| commit | d9e534f6f274d0d8b02a6258a55d6178517bd5fa (patch) | |
| tree | 70689e6315a49d187d7cc5726675971ae249e573 | |
| parent | 101f234a1637b995e771b4999afdf4793ffdc86e (diff) | |
stm32l476disco: fix uninitialized filed usage
Field PLLState was not initialized in RCC_OscInitStruct.PLL in
function SystemClock_Config().
Value is used in HAL_RCC_OscConfig() regardless of oscillator.
In lucky case value would be 0 RCC_PLL_NONE and nothing would
happen.
If value was incorrect following line would end up in assert:
assert_param(IS_RCC_PLL(RCC_OscInitStruct->PLL.PLLState));
If value was valid but no RCC_PLL_NONE pll could be configured
with some other random values.
Setting PLLState to RCC_PLL_NONE eliminates potential problem.
| -rw-r--r-- | hw/bsp/stm32l476disco/stm32l476disco.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/bsp/stm32l476disco/stm32l476disco.c b/hw/bsp/stm32l476disco/stm32l476disco.c index 2d4a4e3de..3ecfc90a6 100644 --- a/hw/bsp/stm32l476disco/stm32l476disco.c +++ b/hw/bsp/stm32l476disco/stm32l476disco.c @@ -86,9 +86,10 @@ static void SystemClock_Config(void) RCC_OscInitTypeDef RCC_OscInitStruct; RCC_PeriphCLKInitTypeDef PeriphClkInitStruct; - /* Enable the LSE Oscilator */ + /* Enable the LSE Oscillator */ RCC_OscInitStruct.OscillatorType = RCC_OSCILLATORTYPE_LSE; RCC_OscInitStruct.LSEState = RCC_LSE_ON; + RCC_OscInitStruct.PLL.PLLState = RCC_PLL_NONE; HAL_RCC_OscConfig(&RCC_OscInitStruct); /* Enable the CSS interrupt in case LSE signal is corrupted or not present */ |