summaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
authorhathach <[email protected]>2026-09-04 04:56:19 +0700
committerhathach <[email protected]>2026-09-04 04:56:19 +0700
commit479b0fdd8910aa3d5db6964a0065e2893a5f809a (patch)
tree25347ef5fd39bb9abc441004ae71c844de6f3825 /docs
parent94f93aaba4bb4b33e9f215911f719b74a5dec141 (diff)
skills, docs: address review on the harness audit
The WCH lock header path sat across a code-span line break and rendered with a space in it. The pool-check reporting list had dropped the scan-mode disclosure the same file requires. The pr3840 handoff still described the no-boards bullet as unfixed; it now records the doc half as landed and keeps only the missing test.
Diffstat (limited to 'docs')
-rw-r--r--docs/superpowers/followup/pr3840-skill-md-no-boards-drift.md38
1 files changed, 11 insertions, 27 deletions
diff --git a/docs/superpowers/followup/pr3840-skill-md-no-boards-drift.md b/docs/superpowers/followup/pr3840-skill-md-no-boards-drift.md
index a039a8c12..840d2a074 100644
--- a/docs/superpowers/followup/pr3840-skill-md-no-boards-drift.md
+++ b/docs/superpowers/followup/pr3840-skill-md-no-boards-drift.md
@@ -1,35 +1,19 @@
-# `SKILL.md` contradicts the code on no-boards tables
+# `SKILL.md` no-boards bullet: the regression test is still missing
**Origin:** split out of PR #3840, surfaced by its second review round. Delete this file
when its own PR lands.
-`.claude/skills/hil/SKILL.md:150-151` tells the reading agent:
+The documentation half landed in PR #3881. `.claude/skills/hil/SKILL.md`'s
+`**HIL run selected no boards.**` bullet (under "Reporting") now describes both cases: a
+fresh run renders no table, and an `--accumulate` run keeps the previous attempt's rows
+under the notice, which are not this run's and must not be reported as such. That matches
+the code, which deliberately preserves accumulated rows on a no-boards exit because wiping
+them destroyed real results.
-> `**HIL run selected no boards.**` — the filters intersected to nothing, so there is **no
-> table at all**. Report that (and the filter shown), never `"pass": true`.
-
-That was true when the no-boards exit wrote a bare notice. It no longer is. An
-`--accumulate` no-boards run keeps the accumulated rows — deliberately, because wiping them
-destroyed real results — so the artifact now reads:
-
-```
-**HIL run selected no boards.** filters emptied
-
-**✅ 1 passed · ❌ 0 failed · ⚪ 0 skipped · blank not run**
-
-| Board | t | duration |
-...
-```
-
-The behaviour is correct; the documentation is wrong, and wrong in the direction that
-matters. An agent is told to expect no table, sees one, and has no rule for whether those
-rows are reportable. **They are not this run's** — they are a previous attempt's, carried
-forward.
-
-**What remains:** update that bullet to describe both cases — a fresh run has no table, an
-`--accumulate` run shows the previous attempt's rows under the notice and they must not be
-reported as this run's. Add a test asserting the fresh case renders no matrix, so the two
-halves cannot drift again.
+**What remains:** a test asserting that the fresh no-boards case renders no matrix while
+the `--accumulate` case keeps the prior rows under the notice, so the two halves cannot
+drift again. The behaviour lives in `test/hil/helper/hil_report.py`'s no-boards exit
+(`accumulate_report` with `fresh`); `test/hil/test/test_hil_report.py` is the suite.
## Why it was split out