Merge pull request #89 from hathach/develop

resolve #35 (vendor class), implement #86 (webusb)

4 files changed, 215 insertions, 103 deletions

diff --git a/src/device/usbd.c b/src/device/usbd.c
index a68953151..a6eda79de 100644
--- a/src/device/usbd.c
+++ b/src/device/usbd.c
@@ -43,20 +43,20 @@
 typedef struct {

   struct TU_ATTR_PACKED

   {

-      volatile uint8_t connected    : 1;

-      volatile uint8_t configured   : 1;

-      volatile uint8_t suspended    : 1;

+    volatile uint8_t connected    : 1;

+    volatile uint8_t configured   : 1;

+    volatile uint8_t suspended    : 1;

 

-      uint8_t remote_wakeup_en      : 1; // enable/disable by host

-      uint8_t remote_wakeup_support : 1; // configuration descriptor's attribute

-      uint8_t self_powered          : 1; // configuration descriptor's attribute

+    uint8_t remote_wakeup_en      : 1; // enable/disable by host

+    uint8_t remote_wakeup_support : 1; // configuration descriptor's attribute

+    uint8_t self_powered          : 1; // configuration descriptor's attribute

   };

 

   uint8_t ep_busy_map[2];  // bit mask for busy endpoint

   uint8_t ep_stall_map[2]; // bit map for stalled endpoint

 

-  uint8_t itf2drv[16];      // map interface number to driver (0xff is invalid)

-  uint8_t ep2drv[8][2];     // map endpoint to driver ( 0xff is invalid )

+  uint8_t itf2drv[16];     // map interface number to driver (0xff is invalid)

+  uint8_t ep2drv[8][2];    // map endpoint to driver ( 0xff is invalid )

 }usbd_device_t;

 

 static usbd_device_t _usbd_dev = { 0 };

@@ -67,80 +67,80 @@ static usbd_device_t _usbd_dev = { 0 };
 typedef struct {

   uint8_t class_code;

 

-  void (* init           ) (void);

-  bool (* open           ) (uint8_t rhport, tusb_desc_interface_t const * desc_intf, uint16_t* p_length);

-  bool (* control_request ) (uint8_t rhport, tusb_control_request_t const * request);

-  bool (* control_request_complete ) (uint8_t rhport, tusb_control_request_t const * request);

-  bool (* xfer_cb        ) (uint8_t rhport, uint8_t ep_addr, xfer_result_t, uint32_t);

-  void (* sof            ) (uint8_t rhport);

-  void (* reset          ) (uint8_t);

+  void (* init             ) (void);

+  void (* reset            ) (uint8_t rhport);

+  bool (* open             ) (uint8_t rhport, tusb_desc_interface_t const * desc_intf, uint16_t* p_length);

+  bool (* control_request  ) (uint8_t rhport, tusb_control_request_t const * request);

+  bool (* control_complete ) (uint8_t rhport, tusb_control_request_t const * request);

+  bool (* xfer_cb          ) (uint8_t rhport, uint8_t ep_addr, xfer_result_t event, uint32_t xferred_bytes);

+  void (* sof              ) (uint8_t rhport);

 } usbd_class_driver_t;

 

 static usbd_class_driver_t const usbd_class_drivers[] =

 {

   #if CFG_TUD_CDC

-    {

-        .class_code      = TUSB_CLASS_CDC,

-        .init            = cdcd_init,

-        .open            = cdcd_open,

-        .control_request = cdcd_control_request,

-        .control_request_complete = cdcd_control_request_complete,

-        .xfer_cb         = cdcd_xfer_cb,

-        .sof             = NULL,

-        .reset           = cdcd_reset

-    },

+  {

+      .class_code       = TUSB_CLASS_CDC,

+      .init             = cdcd_init,

+      .reset            = cdcd_reset,

+      .open             = cdcd_open,

+      .control_request  = cdcd_control_request,

+      .control_complete = cdcd_control_complete,

+      .xfer_cb          = cdcd_xfer_cb,

+      .sof              = NULL

+  },

   #endif

 

   #if CFG_TUD_MSC

-    {

-        .class_code      = TUSB_CLASS_MSC,

-        .init            = mscd_init,

-        .open            = mscd_open,

-        .control_request = mscd_control_request,

-        .control_request_complete = mscd_control_request_complete,

-        .xfer_cb         = mscd_xfer_cb,

-        .sof             = NULL,

-        .reset           = mscd_reset

-    },

+  {

+      .class_code       = TUSB_CLASS_MSC,

+      .init             = mscd_init,

+      .reset            = mscd_reset,

+      .open             = mscd_open,

+      .control_request  = mscd_control_request,

+      .control_complete = mscd_control_complete,

+      .xfer_cb          = mscd_xfer_cb,

+      .sof              = NULL

+  },

   #endif

 

   #if CFG_TUD_HID

-    {

-        .class_code      = TUSB_CLASS_HID,

-        .init            = hidd_init,

-        .open            = hidd_open,

-        .control_request = hidd_control_request,

-        .control_request_complete = hidd_control_request_complete,

-        .xfer_cb         = hidd_xfer_cb,

-        .sof             = NULL,

-        .reset           = hidd_reset

-    },

+  {

+      .class_code       = TUSB_CLASS_HID,

+      .init             = hidd_init,

+      .reset            = hidd_reset,

+      .open             = hidd_open,

+      .control_request  = hidd_control_request,

+      .control_complete = hidd_control_complete,

+      .xfer_cb          = hidd_xfer_cb,

+      .sof              = NULL

+  },

   #endif

 

   #if CFG_TUD_MIDI

-    {

-        .class_code      = TUSB_CLASS_AUDIO,

-        .init            = midid_init,

-        .open            = midid_open,

-        .control_request = midid_control_request,

-        .control_request_complete = midid_control_request_complete,

-        .xfer_cb         = midid_xfer_cb,

-        .sof             = NULL,

-        .reset           = midid_reset

-    },

+  {

+      .class_code       = TUSB_CLASS_AUDIO,

+      .init             = midid_init,

+      .open             = midid_open,

+      .reset            = midid_reset,

+      .control_request  = midid_control_request,

+      .control_complete = midid_control_complete,

+      .xfer_cb          = midid_xfer_cb,

+      .sof              = NULL

+  },

   #endif

 

-  #if CFG_TUD_CUSTOM_CLASS

-    {

-        .class_code      = TUSB_CLASS_VENDOR_SPECIFIC,

-        .init            = cusd_init,

-        .open            = cusd_open,

-        .control_request = cusd_control_request,

-        .control_request_complete = cusd_control_request_complete,

-        .xfer_cb         = cusd_xfer_cb,

-        .sof             = NULL,

-        .reset           = cusd_reset

-    },

+  #if CFG_TUD_VENDOR

+  {

+      .class_code       = TUSB_CLASS_VENDOR_SPECIFIC,

+      .init             = vendord_init,

+      .reset            = vendord_reset,

+      .open             = vendord_open,

+      .control_request  = tud_vendor_control_request_cb,

+      .control_complete = tud_vendor_control_complete_cb,

+      .xfer_cb          = vendord_xfer_cb,

+      .sof              = NULL

+  },

   #endif

 };

 

@@ -237,7 +237,6 @@ static void usbd_reset(uint8_t rhport)
       while(1) // the mainloop

       {

         application_code();

-

         tud_task(); // tinyusb device task

       }

     }

@@ -347,6 +346,15 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
 {

   usbd_control_set_complete_callback(NULL);

 

+  // Vendor request

+  if ( p_request->bmRequestType_bit.type == TUSB_REQ_TYPE_VENDOR )

+  {

+    TU_VERIFY(tud_vendor_control_request_cb);

+

+    if (tud_vendor_control_complete_cb) usbd_control_set_complete_callback(tud_vendor_control_complete_cb);

+    return tud_vendor_control_request_cb(rhport, p_request);

+  }

+

   switch ( p_request->bmRequestType_bit.recipient )

   {

     //------------- Device Requests e.g in enumeration -------------//

@@ -370,7 +378,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
         case TUSB_REQ_GET_CONFIGURATION:

         {

           uint8_t cfgnum = _usbd_dev.configured ? 1 : 0;

-          usbd_control_xfer(rhport, p_request, &cfgnum, 1);

+          tud_control_xfer(rhport, p_request, &cfgnum, 1);

         }

         break;

 

@@ -382,7 +390,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
           _usbd_dev.configured = cfg_num ? 1 : 0;

 

           if ( cfg_num ) TU_ASSERT( process_set_config(rhport, cfg_num) );

-          usbd_control_status(rhport, p_request);

+          tud_control_status(rhport, p_request);

         }

         break;

 

@@ -396,7 +404,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
 

           // Host may enable remote wake up before suspending especially HID device

           _usbd_dev.remote_wakeup_en = true;

-          usbd_control_status(rhport, p_request);

+          tud_control_status(rhport, p_request);

         break;

 

         case TUSB_REQ_CLEAR_FEATURE:

@@ -405,7 +413,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
 

           // Host may disable remote wake up after resuming

           _usbd_dev.remote_wakeup_en = false;

-          usbd_control_status(rhport, p_request);

+          tud_control_status(rhport, p_request);

         break;

 

         case TUSB_REQ_GET_STATUS:

@@ -414,7 +422,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
           // - Bit 0: Self Powered

           // - Bit 1: Remote Wakeup enabled

           uint16_t status = (_usbd_dev.self_powered ? 1 : 0) | (_usbd_dev.remote_wakeup_en ? 2 : 0);

-          usbd_control_xfer(rhport, p_request, &status, 2);

+          tud_control_xfer(rhport, p_request, &status, 2);

         }

         break;

 

@@ -431,10 +439,34 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
 

       TU_VERIFY(drvid < USBD_CLASS_DRIVER_COUNT);

 

-      usbd_control_set_complete_callback(usbd_class_drivers[drvid].control_request_complete );

+      switch ( p_request->bRequest )

+      {

+        case TUSB_REQ_GET_INTERFACE:

+        {

+          // TODO not support alternate interface yet

+          uint8_t alternate = 0;

+          tud_control_xfer(rhport, p_request, &alternate, 1);

+        }

+        break;

+

+        case TUSB_REQ_SET_INTERFACE:

+        {

+          uint8_t alternate = (uint8_t) p_request->wValue;

+

+          // TODO not support alternate interface yet

+          TU_ASSERT(alternate == 0);

 

-      // stall control endpoint if driver return false

-      return usbd_class_drivers[drvid].control_request(rhport, p_request);

+          tud_control_status(rhport, p_request);

+        }

+        break;

+

+        default:

+          // forward to class driver

+          // stall control endpoint if driver return false

+          usbd_control_set_complete_callback(usbd_class_drivers[drvid].control_complete);

+          TU_ASSERT(usbd_class_drivers[drvid].control_request(rhport, p_request));

+        break;

+      }

     }

     break;

 

@@ -448,7 +480,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
         case TUSB_REQ_GET_STATUS:

         {

           uint16_t status = usbd_edpt_stalled(rhport, tu_u16_low(p_request->wIndex)) ? 0x0001 : 0x0000;

-          usbd_control_xfer(rhport, p_request, &status, 2);

+          tud_control_xfer(rhport, p_request, &status, 2);

         }

         break;

 

@@ -457,7 +489,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
           {

             usbd_edpt_clear_stall(rhport, tu_u16_low(p_request->wIndex));

           }

-          usbd_control_status(rhport, p_request);

+          tud_control_status(rhport, p_request);

         break;

 

         case TUSB_REQ_SET_FEATURE:

@@ -465,7 +497,7 @@ static bool process_control_request(uint8_t rhport, tusb_control_request_t const
           {

             usbd_edpt_stall(rhport, tu_u16_low(p_request->wIndex));

           }

-          usbd_control_status(rhport, p_request);

+          tud_control_status(rhport, p_request);

         break;

 

         // Unknown/Unsupported request

@@ -520,7 +552,7 @@ static bool process_set_config(uint8_t rhport, uint8_t cfg_num)
       _usbd_dev.itf2drv[desc_itf->bInterfaceNumber] = drv_id;

 

       uint16_t itf_len=0;

-      TU_ASSERT( usbd_class_drivers[drv_id].open( rhport, desc_itf, &itf_len ) );

+      TU_ASSERT( usbd_class_drivers[drv_id].open(rhport, desc_itf, &itf_len) );

       TU_ASSERT( itf_len >= sizeof(tusb_desc_interface_t) );

 

       mark_interface_endpoint(_usbd_dev.ep2drv, p_desc, itf_len, drv_id);

@@ -563,13 +595,29 @@ static bool process_get_descriptor(uint8_t rhport, tusb_control_request_t const
   switch(desc_type)

   {

     case TUSB_DESC_DEVICE:

-      return usbd_control_xfer(rhport, p_request, (void*) tud_descriptor_device_cb(), sizeof(tusb_desc_device_t));

+      return tud_control_xfer(rhport, p_request, (void*) tud_descriptor_device_cb(), sizeof(tusb_desc_device_t));

+    break;

+

+    case TUSB_DESC_BOS:

+    {

+      // requested by host if USB > 2.0 ( i.e 2.1 or 3.x )

+      if (!tud_descriptor_bos_cb) return false;

+

+      tusb_desc_bos_t const* desc_bos = (tusb_desc_bos_t const*) tud_descriptor_bos_cb();

+      uint16_t total_len;

+      memcpy(&total_len, &desc_bos->wTotalLength, 2); // possibly mis-aligned memory

+

+      return tud_control_xfer(rhport, p_request, (void*) desc_bos, total_len);

+    }

     break;

 

     case TUSB_DESC_CONFIGURATION:

     {

       tusb_desc_configuration_t const* desc_config = (tusb_desc_configuration_t const*) tud_descriptor_configuration_cb(desc_index);

-      return usbd_control_xfer(rhport, p_request, (void*) desc_config, desc_config->wTotalLength);

+      uint16_t total_len;

+      memcpy(&total_len, &desc_config->wTotalLength, 2); // possibly mis-aligned memory

+

+      return tud_control_xfer(rhport, p_request, (void*) desc_config, total_len);

     }

     break;

 

@@ -577,8 +625,8 @@ static bool process_get_descriptor(uint8_t rhport, tusb_control_request_t const
       // String Descriptor always uses the desc set from user

       if ( desc_index == 0xEE )

       {

-        // The 0xEE index string is a Microsoft USB extension.

-        // It can be used to tell Windows what driver it should use for the device !!!

+        // The 0xEE index string is a Microsoft OS Descriptors.

+        // https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/microsoft-defined-usb-descriptors

         return false;

       }else

       {

@@ -586,7 +634,7 @@ static bool process_get_descriptor(uint8_t rhport, tusb_control_request_t const
         TU_ASSERT(desc_str);

 

         // first byte of descriptor is its size

-        return usbd_control_xfer(rhport, p_request, (void*) desc_str, desc_str[0]);

+        return tud_control_xfer(rhport, p_request, (void*) desc_str, desc_str[0]);

       }

     break;

 

diff --git a/src/device/usbd.h b/src/device/usbd.h
index 8eee20c0a..6e781f18d 100644
--- a/src/device/usbd.h
+++ b/src/device/usbd.h
@@ -59,6 +59,14 @@ static inline bool tud_ready(void)
 // Remote wake up host, only if suspended and enabled by host

 bool tud_remote_wakeup(void);

 

+// Carry out Data and Status stage of control transfer

+// - If len = 0, it is equivalent to sending status only

+// - If len > wLength : it will be truncated

+bool tud_control_xfer(uint8_t rhport, tusb_control_request_t const * request, void* buffer, uint16_t len);

+

+// Send STATUS (zero length) packet

+bool tud_control_status(uint8_t rhport, tusb_control_request_t const * request);

+

 //--------------------------------------------------------------------+

 // Application Callbacks (WEAK is optional)

 //--------------------------------------------------------------------+

@@ -67,6 +75,10 @@ bool tud_remote_wakeup(void);
 // Application return pointer to descriptor

 uint8_t const * tud_descriptor_device_cb(void);

 

+// Invoked when received GET BOS DESCRIPTOR request

+// Application return pointer to descriptor

+TU_ATTR_WEAK uint8_t const * tud_descriptor_bos_cb(void);

+

 // Invoked when received GET CONFIGURATION DESCRIPTOR request

 // Application return pointer to descriptor, whose contents must exist long enough for transfer to complete

 uint8_t const * tud_descriptor_configuration_cb(uint8_t index);

@@ -88,10 +100,56 @@ TU_ATTR_WEAK void tud_suspend_cb(bool remote_wakeup_en);
 // Invoked when usb bus is resumed

 TU_ATTR_WEAK void tud_resume_cb(void);

 

+// Invoked when received control request with VENDOR TYPE

+TU_ATTR_WEAK bool tud_vendor_control_request_cb(uint8_t rhport, tusb_control_request_t const * request);

+TU_ATTR_WEAK bool tud_vendor_control_complete_cb(uint8_t rhport, tusb_control_request_t const * request);

+

+

 //--------------------------------------------------------------------+

-// Interface Descriptor Template

+// Binary Device Object Store (BOS) Descriptor Templates

 //--------------------------------------------------------------------+

 

+#define TUD_BOS_DESC_LEN      5

+

+// total length, number of device caps

+#define TUD_BOS_DESCRIPTOR(_total_len, _caps_num) \

+  5, TUSB_DESC_BOS, U16_TO_U8S_LE(_total_len), _caps_num

+

+// Device Capability Platform 128-bit UUID + Data

+#define TUD_BOS_PLATFORM_DESCRIPTOR(...) \

+  4+TU_ARGS_NUM(__VA_ARGS__), TUSB_DESC_DEVICE_CAPABILITY, DEVICE_CAPABILITY_PLATFORM, 0x00, __VA_ARGS__

+

+//------------- WebUSB BOS Platform -------------//

+

+// Descriptor Length

+#define TUD_BOS_WEBUSB_DESC_LEN         24

+

+// Vendor Code, iLandingPage

+#define TUD_BOS_WEBUSB_DESCRIPTOR(_vendor_code, _ipage) \

+  TUD_BOS_PLATFORM_DESCRIPTOR(TUD_BOS_WEBUSB_UUID, U16_TO_U8S_LE(0x0100), _vendor_code, _ipage)

+

+#define TUD_BOS_WEBUSB_UUID   \

+  0x38, 0xB6, 0x08, 0x34, 0xA9, 0x09, 0xA0, 0x47, \

+  0x8B, 0xFD, 0xA0, 0x76, 0x88, 0x15, 0xB6, 0x65

+

+//------------- Microsoft OS 2.0 Platform -------------//

+

+#define TUD_BOS_MICROSOFT_OS_DESC_LEN   28

+

+// Total Length of descriptor set, vendor code

+#define TUD_BOS_MS_OS_20_DESCRIPTOR(_desc_set_len, _vendor_code) \

+  TUD_BOS_PLATFORM_DESCRIPTOR(TUD_BOS_MS_OS_20_UUID, U32_TO_U8S_LE(0x06030000), U16_TO_U8S_LE(_desc_set_len), _vendor_code, 0)

+

+#define TUD_BOS_MS_OS_20_UUID \

+  0xDF, 0x60, 0xDD, 0xD8, 0x89, 0x45, 0xC7, 0x4C, \

+  0x9C, 0xD2, 0x65, 0x9D, 0x9E, 0x64, 0x8A, 0x9F

+

+

+//--------------------------------------------------------------------+

+// Configuration & Interface Descriptor Templates

+//--------------------------------------------------------------------+

+

+//------------- Configuration -------------//

 #define TUD_CONFIG_DESC_LEN   (9)

 

 // Interface count, string index, total length, attribute, power in mA

@@ -160,16 +218,16 @@ TU_ATTR_WEAK void tud_resume_cb(void);
 #define TUD_HID_INOUT_DESC_LEN    (9 + 9 + 7 + 7)

 

 // HID Input & Output descriptor

-// Interface number, string index, protocol, report descriptor len, EP In & Out address, size & polling interval

-#define TUD_HID_INOUT_DESCRIPTOR(_itfnum, _stridx, _boot_protocol, _report_desc_len, _epin, _epout, _epsize, _ep_interval) \

+// Interface number, string index, protocol, report descriptor len, EP OUT & IN address, size & polling interval

+#define TUD_HID_INOUT_DESCRIPTOR(_itfnum, _stridx, _boot_protocol, _report_desc_len, _epout, _epin, _epsize, _ep_interval) \

   /* Interface */\

   9, TUSB_DESC_INTERFACE, _itfnum, 0, 2, TUSB_CLASS_HID, (_boot_protocol) ? HID_SUBCLASS_BOOT : 0, _boot_protocol, _stridx,\

   /* HID descriptor */\

   9, HID_DESC_TYPE_HID, U16_TO_U8S_LE(0x0111), 0, 1, HID_DESC_TYPE_REPORT, U16_TO_U8S_LE(_report_desc_len),\

-  /* Endpoint In */\

-  7, TUSB_DESC_ENDPOINT, _epin, TUSB_XFER_INTERRUPT, U16_TO_U8S_LE(_epsize), _ep_interval,\

   /* Endpoint Out */\

-  7, TUSB_DESC_ENDPOINT, _epout, TUSB_XFER_INTERRUPT, U16_TO_U8S_LE(_epsize), _ep_interval

+  7, TUSB_DESC_ENDPOINT, _epout, TUSB_XFER_INTERRUPT, U16_TO_U8S_LE(_epsize), _ep_interval, \

+  /* Endpoint In */\

+  7, TUSB_DESC_ENDPOINT, _epin, TUSB_XFER_INTERRUPT, U16_TO_U8S_LE(_epsize), _ep_interval

 

 //------------- MIDI -------------//

 

@@ -205,6 +263,18 @@ TU_ATTR_WEAK void tud_resume_cb(void);
   /* MS Endpoint (connected to embedded jack out) */\

   5, TUSB_DESC_CS_ENDPOINT, MIDI_CS_ENDPOINT_GENERAL, 1, 3

 

+//------------- Vendor -------------//

+#define TUD_VENDOR_DESC_LEN  (9+7+7)

+

+// Interface number, string index, EP Out & IN address, EP size

+#define TUD_VENDOR_DESCRIPTOR(_itfnum, _stridx, _epout, _epin, _epsize) \

+  /* Interface */\

+  9, TUSB_DESC_INTERFACE, _itfnum, 0, 2, TUSB_CLASS_VENDOR_SPECIFIC, 0x00, 0x00, _stridx,\

+  /* Endpoint Out */\

+  7, TUSB_DESC_ENDPOINT, _epout, TUSB_XFER_BULK, U16_TO_U8S_LE(_epsize), 0,\

+  /* Endpoint In */\

+  7, TUSB_DESC_ENDPOINT, _epin, TUSB_XFER_BULK, U16_TO_U8S_LE(_epsize), 0

+

 

 #ifdef __cplusplus

  }

diff --git a/src/device/usbd_control.c b/src/device/usbd_control.c
index 49293b832..f4b9d6219 100644
--- a/src/device/usbd_control.c
+++ b/src/device/usbd_control.c
@@ -59,7 +59,7 @@ void usbd_control_reset (uint8_t rhport)
   tu_varclr(&_control_state);

 }

 

-bool usbd_control_status(uint8_t rhport, tusb_control_request_t const * request)

+bool tud_control_status(uint8_t rhport, tusb_control_request_t const * request)

 {

   // status direction is reversed to one in the setup packet

   return dcd_edpt_xfer(rhport, request->bmRequestType_bit.direction ? EDPT_CTRL_OUT : EDPT_CTRL_IN, NULL, 0);

@@ -87,7 +87,7 @@ void usbd_control_set_complete_callback( bool (*fp) (uint8_t, tusb_control_reque
   _control_state.complete_cb = fp;

 }

 

-bool usbd_control_xfer(uint8_t rhport, tusb_control_request_t const * request, void* buffer, uint16_t len)

+bool tud_control_xfer(uint8_t rhport, tusb_control_request_t const * request, void* buffer, uint16_t len)

 {

   _control_state.request = (*request);

   _control_state.buffer = buffer;

@@ -103,7 +103,7 @@ bool usbd_control_xfer(uint8_t rhport, tusb_control_request_t const * request, v
   }else

   {

     // Status stage

-    TU_ASSERT( usbd_control_status(rhport, request) );

+    TU_ASSERT( tud_control_status(rhport, request) );

   }

 

   return true;

@@ -139,7 +139,7 @@ bool usbd_control_xfer_cb (uint8_t rhport, uint8_t ep_addr, xfer_result_t result
     if ( is_ok )

     {

       // Send status

-      TU_ASSERT( usbd_control_status(rhport, &_control_state.request) );

+      TU_ASSERT( tud_control_status(rhport, &_control_state.request) );

     }else

     {

       // Stall both IN and OUT control endpoint

diff --git a/src/device/usbd_pvt.h b/src/device/usbd_pvt.h
index 706857d45..fbf030ce3 100644
--- a/src/device/usbd_pvt.h
+++ b/src/device/usbd_pvt.h
@@ -39,19 +39,13 @@ bool usbd_init (void);
 // USBD Endpoint API
 //--------------------------------------------------------------------+
 
-// Carry out Data and Status stage of control transfer
-// - If len = 0, it is equivalent to sending status only
-// - If len > wLength : it will be truncated
-bool usbd_control_xfer(uint8_t rhport, tusb_control_request_t const * request, void* buffer, uint16_t len);
-
-// Send STATUS (zero length) packet
-bool usbd_control_status(uint8_t rhport, tusb_control_request_t const * request);
+//bool usbd_edpt_open(uint8_t rhport, tusb_desc_endpoint_t const * p_endpoint_desc);
 
 // Submit a usb transfer
-bool usbd_edpt_xfer        (uint8_t rhport, uint8_t ep_addr, uint8_t * buffer, uint16_t total_bytes);
+bool usbd_edpt_xfer(uint8_t rhport, uint8_t ep_addr, uint8_t * buffer, uint16_t total_bytes);
 
 // Check if endpoint transferring is complete
-bool usbd_edpt_busy        (uint8_t rhport, uint8_t ep_addr);
+bool usbd_edpt_busy(uint8_t rhport, uint8_t ep_addr);
 
 void usbd_edpt_stall(uint8_t rhport, uint8_t ep_addr);
 void usbd_edpt_clear_stall(uint8_t rhport, uint8_t ep_addr);