diff options
| author | GuavTek <[email protected]> | 2024-11-27 22:19:42 +0100 |
|---|---|---|
| committer | GuavTek <[email protected]> | 2024-11-27 22:19:42 +0100 |
| commit | 4212db1b83e472e669173b94f692e574c9f23720 (patch) | |
| tree | 9fafc38348ad626e21c88c76481b3bed4ec9d528 /src/host | |
| parent | ebcd7067c9b86b8df8a3f9cf07ba76edd9e7440c (diff) | |
Move desc_len sanity checks to start of loops
Diffstat (limited to 'src/host')
| -rw-r--r-- | src/host/usbh.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/host/usbh.c b/src/host/usbh.c index 1b45fd1be..fe5bf1c9e 100644 --- a/src/host/usbh.c +++ b/src/host/usbh.c @@ -1631,6 +1631,13 @@ static bool _parse_configuration_descriptor(uint8_t dev_addr, tusb_desc_configur // parse each interfaces while( p_desc < desc_end ) { + if ( 0 == tu_desc_len(p_desc) ) { + // A zero length descriptor indicates that the device is off spec (e.g. wrong wTotalLength). + // Parsed interfaces should still be usable + TU_LOG_USBH("Encountered a zero-length descriptor after %u bytes\r\n", (uint32_t)p_desc - (uint32_t)desc_cfg); + break; + } + uint8_t assoc_itf_count = 1; // Class will always starts with Interface Association (if any) and then Interface descriptor @@ -1645,13 +1652,6 @@ static bool _parse_configuration_descriptor(uint8_t dev_addr, tusb_desc_configur // desc_iad->bFunctionClass == desc_itf->bInterfaceClass); } - if ( 0 == tu_desc_len(p_desc) ) { - // A zero length descriptor indicates that the wTotalLength field is wrong. - // Parsed interfaces should still be usable - TU_LOG_USBH("Encountered a zero-length descriptor after %u bytes\r\n", (uint32_t)p_desc - (uint32_t)desc_cfg); - break; - } - TU_ASSERT( TUSB_DESC_INTERFACE == tu_desc_type(p_desc) ); tusb_desc_interface_t const* desc_itf = (tusb_desc_interface_t const*) p_desc; |
