diff options
| author | hathach <[email protected]> | 2026-06-13 23:35:35 +0700 |
|---|---|---|
| committer | hathach <[email protected]> | 2026-06-13 23:35:35 +0700 |
| commit | ff57edb3e5e8d36b2783971924bf7373b4fc39bc (patch) | |
| tree | c784ebf4c6067a48bea9dbee652b0d5b37999692 /src | |
| parent | c8c63c30617d23bb604affcad423acbb11f8d10d (diff) | |
hil: make serial write timeout fatal
pyserial's posix write() raises SerialTimeoutException after partial
progress with the byte count lost, so the retry loop re-sent from the
same offset and could duplicate bytes on the wire — surfacing as bogus
data-mismatch failures that look like device firmware bugs.
write_timeout is already a total per-call deadline, so the loop added
duplication risk without extending the budget: write once and treat a
timeout as fatal. Default bumped 2 -> 10 s to keep the old overall
bound; HIL_SERIAL_WRITE_DEADLINE removed.
The per-character CLI loops keep their existing pacing (the 2 ms sleep
between single-byte writes already spaces them on the wire); no
unbounded ser.flush()/tcdrain is added.
Review follow-up for #3643 (hil_test.py l.257/264 findings).
Co-Authored-By: Claude Fable 5 <[email protected]>
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions
