diff options
| author | Andrew Goodbody <[email protected]> | 2025-09-30 10:56:02 +0100 |
|---|---|---|
| committer | Marek Vasut <[email protected]> | 2025-10-28 16:33:15 +0100 |
| commit | 08f4c52c97ab3db174ce292eb86309ee29be5f07 (patch) | |
| tree | 1042bdeaad7af742b033fc3516d6813532cd706b | |
| parent | 76d3b665310885f1a13ff83e818bb42f2cf26213 (diff) | |
usb: ohci-hcd: Null check lurb_priv before dereference
When a variable needs a null check before it is dreferenced ensure that
this is done even in the case of assignment on declaration. This was not
happening for lurb_priv so correct it.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <[email protected]>
| -rw-r--r-- | drivers/usb/host/ohci-hcd.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 234a6f3645d..1d6711ccec4 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c @@ -1040,9 +1040,11 @@ static void dl_transfer_length(td_t *td) static void check_status(td_t *td_list) { urb_priv_t *lurb_priv = td_list->ed->purb; - int urb_len = lurb_priv->length; __u32 *phwHeadP = &td_list->ed->hwHeadP; - int cc; + int cc, urb_len; + + if (lurb_priv) + urb_len = lurb_priv->length; cc = TD_CC_GET(m32_swap(td_list->hwINFO)); if (cc) { |