diff options
| author | Michal Simek <[email protected]> | 2026-04-29 08:29:53 +0200 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2026-05-04 12:58:44 -0600 |
| commit | 0fd32094c04ff736977d88dea02c299a75965c4f (patch) | |
| tree | 3f96b75f9535ce87558e562918da54d4f4bf2864 | |
| parent | 7dd93524eacfec8512700056fcb54a4ba5c8fd8b (diff) | |
bloblist: fix pointer comparison in bloblist_apply_blobs()
The rec_from_blob() function returns a pointer, but the code was
comparing it using "rec <= 0" which is incorrect for pointer types.
Pointers should be compared using "== NULL" or "!= NULL".
Addresses-Coverity-ID: CID 645841: Incorrect expression (BAD_COMPARE)
Signed-off-by: Michal Simek <[email protected]>
Reviewed-by: Ilias Apalodimas <[email protected]>
Reviewed-by: Raymond Mao <[email protected]>
| -rw-r--r-- | common/bloblist.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/bloblist.c b/common/bloblist.c index afed968ce01..d084be89958 100644 --- a/common/bloblist.c +++ b/common/bloblist.c @@ -300,7 +300,7 @@ int bloblist_apply_blobs(uint tag, int (*func)(void **data, int size)) } rec = rec_from_blob(blob - dat_off); - if (rec <= 0) { + if (!rec) { log_err("Blob corrupted\n"); return -ENOENT; } |