summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVishwas Srivastava <[email protected]>2016-01-26 12:46:42 +0530
committerAnatolij Gustschin <[email protected]>2016-02-06 16:39:31 +0100
commit2300184f702656b72394e458bf15f7aaba8af892 (patch)
tree72c09dfd72d37919df07769bd54b90db8d70fe6c
parent1a9115ecfecf8713de077a68e6c8f599a55fc759 (diff)
net: davinci_emac: fix NULL check after pointer dereference
NULL check is made after the pointer dereference. This patch fixes this issue. Signed-off-by: Vishwas Srivastava <[email protected]> CC: Joe Hershberger <[email protected]> Reviewed-by: Tom Rini <[email protected]> Acked-by: Joe Hershberger <[email protected]> Signed-off-by: Anatolij Gustschin <[email protected]>
-rw-r--r--drivers/net/davinci_emac.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 6f2dc8d6488..b0304984028 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -692,8 +692,10 @@ static int davinci_eth_rcv_packet (struct eth_device *dev)
davinci_invalidate_rx_descs();
rx_curr_desc = emac_rx_active_head;
+ if (!rx_curr_desc)
+ return 0;
status = rx_curr_desc->pkt_flag_len;
- if ((rx_curr_desc) && ((status & EMAC_CPPI_OWNERSHIP_BIT) == 0)) {
+ if ((status & EMAC_CPPI_OWNERSHIP_BIT) == 0) {
if (status & EMAC_CPPI_RX_ERROR_FRAME) {
/* Error in packet - discard it and requeue desc */
printf ("WARN: emac_rcv_pkt: Error in packet\n");