diff options
| author | Andrew Goodbody <[email protected]> | 2025-08-04 17:03:58 +0100 |
|---|---|---|
| committer | Peng Fan <[email protected]> | 2025-08-27 15:39:57 +0800 |
| commit | 270798a4209aeb23fce72ebf10e62630f474e431 (patch) | |
| tree | 94d6d36a4bbbe8e5b67a4e3947dbae910d69e327 | |
| parent | 44d321f0092a42b2295bd6eac41199604cf7d8c9 (diff) | |
net: fm: NULL check dev before dereference
In fm_eth_bind there is a dereference of dev before it is NULL checked.
Add a NULL check before the first dereference and remove a later NULL
check that is now redundant.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
| -rw-r--r-- | drivers/net/fm/eth.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/fm/eth.c b/drivers/net/fm/eth.c index c83b789693a..f0e7c0eca42 100644 --- a/drivers/net/fm/eth.c +++ b/drivers/net/fm/eth.c @@ -727,12 +727,15 @@ static int fm_eth_bind(struct udevice *dev) char mac_name[11]; u32 fm, num; + if (!dev) + return -EINVAL; + if (ofnode_read_u32(ofnode_get_parent(dev_ofnode(dev)), "cell-index", &fm)) { printf("FMan node property cell-index missing\n"); return -EINVAL; } - if (dev && dev_read_u32(dev, "cell-index", &num)) { + if (dev_read_u32(dev, "cell-index", &num)) { printf("FMan MAC node property cell-index missing\n"); return -EINVAL; } |