diff options
| author | Andrew Scull <[email protected]> | 2022-05-30 10:00:01 +0000 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2022-06-23 12:58:18 -0400 |
| commit | 337b26e4688720560662246eb7703860b68bd6e2 (patch) | |
| tree | 876a8b9dc5c3581f6e00a7feb5ee6f650e19dd68 | |
| parent | 9121478ee6f2aee381f8fe49d8997d43527d351a (diff) | |
serial: sandbox: Fix buffer underflow in puts
Fix the buffer underflow that would occur if puts is called with length
of zero.
Fixes: efa51f2bd64 ("serial: sandbox: Implement puts")
Cc: Sean Anderson <[email protected]>
Cc: Simon Glass <[email protected]>
Reviewed-by: Sean Anderson <[email protected]>
| -rw-r--r-- | drivers/serial/sandbox.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/serial/sandbox.c b/drivers/serial/sandbox.c index e726e19c46f..13b54921c41 100644 --- a/drivers/serial/sandbox.c +++ b/drivers/serial/sandbox.c @@ -114,7 +114,7 @@ static ssize_t sandbox_serial_puts(struct udevice *dev, const char *s, struct sandbox_serial_priv *priv = dev_get_priv(dev); ssize_t ret; - if (s[len - 1] == '\n') + if (len && s[len - 1] == '\n') priv->start_of_line = true; if (sandbox_serial_enabled) { |