diff options
| author | Vincent Stehlé <[email protected]> | 2025-04-07 19:05:25 +0200 |
|---|---|---|
| committer | Mattijs Korpershoek <[email protected]> | 2025-04-23 09:52:52 +0200 |
| commit | 39a719dce59607d6abcac17cc2683aa9f2162539 (patch) | |
| tree | ac382631f78db11c11321fa4bbb4d4887cd2bbbe | |
| parent | 59310d1ecb9f56a1bac405a5edfa9774f2d90220 (diff) | |
fwu: developerbox: fix dfu alt buffer clearing
The set_dfu_alt_info() function calls the ALLOC_CACHE_ALIGN_BUFFER()
macro to declare a `buf' variable pointer into an array allocated on the
stack. It then calls the memset() function to clear the useable portion
of the array using the idiomatic expression `sizeof(buf)'.
While this would indeed work fine for an array, in the present case we
end up clearing only the size of a pointer.
Fix this by specifying the explicit size `DFU_ALT_BUF_LEN' instead.
Fixes: 6b403ca4dcf4 ("fwu: DeveloperBox: add support for FWU")
Signed-off-by: Vincent Stehlé <[email protected]>
Cc: Masahisa Kojima <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: Jassi Brar <[email protected]>
Reviewed-by: Mattijs Korpershoek <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mattijs Korpershoek <[email protected]>
| -rw-r--r-- | board/socionext/developerbox/fwu_plat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/socionext/developerbox/fwu_plat.c b/board/socionext/developerbox/fwu_plat.c index 26031795b09..a8b111477ef 100644 --- a/board/socionext/developerbox/fwu_plat.c +++ b/board/socionext/developerbox/fwu_plat.c @@ -18,7 +18,7 @@ void set_dfu_alt_info(char *interface, char *devstr) struct mtd_info *mtd; int ret; - memset(buf, 0, sizeof(buf)); + memset(buf, 0, DFU_ALT_BUF_LEN); mtd_probe_devices(); |
