summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <[email protected]>2026-03-26 15:08:17 +0300
committerTom Rini <[email protected]>2026-04-09 12:16:58 -0600
commit3a29dfc92e9d03ca6446ebf4f462307a038caf60 (patch)
tree7766915c97baf9f9f052398c99ae48eda970904b
parentaf7b6bb05a810a0ec94fd864e3477401b3d1b60a (diff)
firmware: scmi: Fix setting the function
Set BIT(10) when the function needs to be set, otherwise the setting is ignored. Fixes: 0cb160f1b629 ("scmi: pinctrl: add pinctrl driver for SCMI") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Peng Fan <[email protected]>
-rw-r--r--drivers/firmware/scmi/pinctrl.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/firmware/scmi/pinctrl.c b/drivers/firmware/scmi/pinctrl.c
index 47f7a8ad9b8..e670538c87f 100644
--- a/drivers/firmware/scmi/pinctrl.c
+++ b/drivers/firmware/scmi/pinctrl.c
@@ -259,6 +259,8 @@ static int scmi_pinctrl_settings_configure_helper(struct udevice *dev,
in->attr = 0;
in->attr |= FIELD_PREP(GENMASK(9, 2), num_configs);
in->attr |= FIELD_PREP(GENMASK(1, 0), select_type);
+ if (function_id != SCMI_PINCTRL_FUNCTION_NONE)
+ in->attr |= BIT(10);
memcpy(in->configs, configs, num_configs * sizeof(u32) * 2);
ret = devm_scmi_process_msg(dev, &msg);