diff options
| author | Andrew Goodbody <[email protected]> | 2025-08-01 11:39:14 +0100 |
|---|---|---|
| committer | Michael Trimarchi <[email protected]> | 2025-08-03 10:20:16 +0200 |
| commit | 4003ed1c1ecfc88092a1d3c65bf432ab7c2ea15f (patch) | |
| tree | cf40e4f9ea68dd22e78a23cc7f9e3f55f92b968c | |
| parent | 42ef9a0b7f26ccd7b657e9686a406ee83b8bd08d (diff) | |
mtd: rawnand: stm32_fmc2: Ensure to return error code
In stm32_fmc2_nfc_probe there are 3 error returns that do not set the
error code before returning which could lead to the error being silently
ignored. Just return -EINVAL in each case.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <[email protected]>
Reviewed-by: Patrice Chotard <[email protected]>
| -rw-r--r-- | drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 083ea4c5a74..d1c88643c98 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -942,21 +942,21 @@ static int stm32_fmc2_nfc_probe(struct udevice *dev) addr = dev_read_addr_index(dev, mem_region); if (addr == FDT_ADDR_T_NONE) { dev_err(dev, "Resource data_base not found for cs%d", chip_cs); - return ret; + return -EINVAL; } nfc->data_base[chip_cs] = addr; addr = dev_read_addr_index(dev, mem_region + 1); if (addr == FDT_ADDR_T_NONE) { dev_err(dev, "Resource cmd_base not found for cs%d", chip_cs); - return ret; + return -EINVAL; } nfc->cmd_base[chip_cs] = addr; addr = dev_read_addr_index(dev, mem_region + 2); if (addr == FDT_ADDR_T_NONE) { dev_err(dev, "Resource addr_base not found for cs%d", chip_cs); - return ret; + return -EINVAL; } nfc->addr_base[chip_cs] = addr; } |