diff options
| author | Michal Simek <[email protected]> | 2026-04-02 17:36:58 +0200 |
|---|---|---|
| committer | Heinrich Schuchardt <[email protected]> | 2026-04-17 08:02:42 +0200 |
| commit | 583efb5040587f06bab5f5d3eb321186c3a39fe4 (patch) | |
| tree | 70565a3c72924415363e60deb40785cdd4dc1ce3 | |
| parent | 57eae396ec91729d5655c26456f8ac3bac439202 (diff) | |
event: Check return value from event_notify_null()
event_notify_null() returns int but its return value is not
checked in run_main_loop() and in fwu_mdata tests.
Add proper error checking to all unchecked call sites.
Signed-off-by: Michal Simek <[email protected]>
Reviewed-by: Simon Glass <[email protected]>
Acked-by: Ilias Apalodimas <[email protected]>
| -rw-r--r-- | common/board_r.c | 6 | ||||
| -rw-r--r-- | test/dm/fwu_mdata.c | 4 |
2 files changed, 7 insertions, 3 deletions
diff --git a/common/board_r.c b/common/board_r.c index 8cf0e14679c..5d37345ca09 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -569,11 +569,15 @@ static int dm_announce(void) static int run_main_loop(void) { + int ret; + #ifdef CONFIG_SANDBOX sandbox_main_loop_init(); #endif - event_notify_null(EVT_MAIN_LOOP); + ret = event_notify_null(EVT_MAIN_LOOP); + if (ret) + return ret; /* main_loop() can return to retry autoboot, if so just run it again */ for (;;) diff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c index b7680632f95..643b647af0a 100644 --- a/test/dm/fwu_mdata.c +++ b/test/dm/fwu_mdata.c @@ -100,7 +100,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state *uts) * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks() * to populate g_dev global pointer in that library. */ - event_notify_null(EVT_MAIN_LOOP); + ut_assertok(event_notify_null(EVT_MAIN_LOOP)); ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev)); ut_assertok(fwu_init()); @@ -127,7 +127,7 @@ static int dm_test_fwu_mdata_write(struct unit_test_state *uts) * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks() * to populate g_dev global pointer in that library. */ - event_notify_null(EVT_MAIN_LOOP); + ut_assertok(event_notify_null(EVT_MAIN_LOOP)); ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev)); |