diff options
| author | Peng Fan <[email protected]> | 2015-12-23 12:07:24 +0800 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2016-01-04 12:25:35 -0500 |
| commit | 5a6894397a657edec5d0cf4e20968cc66a368c51 (patch) | |
| tree | 8c3329a5f32d195b2b9161b72000f619c35a804d | |
| parent | 09a788624dbe32aeeb0d74c97c0965303eb96d8c (diff) | |
common: env: initialize scalar variable
Before calling hsearch_r, initialize callback entry to NULL.
Coverity log:
"
Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value e.
Field e.callback is uninitialized when calling hsearch_r.
"
Reported-by: Coverity
Signed-off-by: Peng Fan <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: Simon Glass <[email protected]>
| -rw-r--r-- | common/env_callback.c | 1 | ||||
| -rw-r--r-- | common/env_flags.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/common/env_callback.c b/common/env_callback.c index f4d3dbd77fa..1957cc19964 100644 --- a/common/env_callback.c +++ b/common/env_callback.c @@ -97,6 +97,7 @@ static int set_callback(const char *name, const char *value, void *priv) e.key = name; e.data = NULL; + e.callback = NULL; hsearch_r(e, FIND, &ep, &env_htab, 0); /* does the env variable actually exist? */ diff --git a/common/env_flags.c b/common/env_flags.c index e682d851789..771935508cb 100644 --- a/common/env_flags.c +++ b/common/env_flags.c @@ -455,6 +455,7 @@ static int set_flags(const char *name, const char *value, void *priv) e.key = name; e.data = NULL; + e.callback = NULL; hsearch_r(e, FIND, &ep, &env_htab, 0); /* does the env variable actually exist? */ |