diff options
| author | Nikita Shubin <[email protected]> | 2026-02-26 19:39:10 +0300 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2026-03-13 13:21:59 -0600 |
| commit | 660d8e4fe92e4ca3f2173e3d00a25f6ae5f6e97d (patch) | |
| tree | 8749a3d7584390cb0440f2ce34a0caa85c57bb14 | |
| parent | 6a23c079b877820195ebca0b98f78abb66f47497 (diff) | |
serial: ns16550: Fix return-type warning
Fix compiler warning:
drivers/serial/ns16550.c: In function ‘serial_in_dynamic’:
drivers/serial/ns16550.c:153:1: warning: control reaches end
of non-void function [-Wreturn-type]
153 | }
| ^
Observed with gcc 15.2.1:
$ riscv64-unknown-linux-gnu-gcc --version
riscv64-unknown-linux-gnu-gcc (Gentoo 15.2.1_p20260214 p5) 15.2.1
Fixes: 62cbde4c4e46 ("serial: ns16550: Support run-time configuration")
Signed-off-by: Nikita Shubin <[email protected]>
Reviewed-by: Tom Rini <[email protected]>
| -rw-r--r-- | drivers/serial/ns16550.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index c885b46cf56..2f24f47badf 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -137,9 +137,9 @@ static int serial_in_dynamic(struct ns16550_plat *plat, u8 *addr) } } else if (plat->flags & NS16550_FLAG_BE) { return readb(addr + (1 << plat->reg_shift) - 1); - } else { - return readb(addr); } + + return readb(addr); } #else static inline void serial_out_dynamic(struct ns16550_plat *plat, u8 *addr, |