diff options
| author | Tom Rini <[email protected]> | 2018-04-22 09:47:48 -0400 |
|---|---|---|
| committer | Anatolij Gustschin <[email protected]> | 2018-04-24 20:57:14 +0200 |
| commit | 751641814c1db245695dd8f40e9c811320e69f79 (patch) | |
| tree | abdb958b3a0dbce51c1f6ef67a4bc88df2a3da8f | |
| parent | 02325c7bfd7ccafae600774273f1b8ac11e90c08 (diff) | |
video-uclass: Fix logical-not-parentheses warning
With clang-4.0 and later we see:
warning: logical not is only applied to the left hand side of this bitwise
operator [-Wlogical-not-parentheses]
if ((!gd->flags & GD_FLG_RELOC))
^ ~
And while the compiler suggests adding parenthesis around gd->flags, a
reading of the code says that we want to know when GD_FLG_RELOC is not
set and then return.
Cc: Simon Glass <[email protected]>
Cc: Anatolij Gustschin <[email protected]>
Signed-off-by: Tom Rini <[email protected]>
| -rw-r--r-- | drivers/video/video-uclass.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index b5bb8e0efde..93fdc6828b1 100644 --- a/drivers/video/video-uclass.c +++ b/drivers/video/video-uclass.c @@ -272,7 +272,7 @@ static int video_post_bind(struct udevice *dev) ulong size; /* Before relocation there is nothing to do here */ - if ((!gd->flags & GD_FLG_RELOC)) + if (!(gd->flags & GD_FLG_RELOC)) return 0; size = alloc_fb(dev, &addr); if (addr < gd->video_bottom) { |