diff options
| author | Jerome Forissier <[email protected]> | 2024-11-18 15:31:25 +0100 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2024-11-22 14:37:49 -0600 |
| commit | 7d80e7368e1012355695e1fb580e5b20c8de03b9 (patch) | |
| tree | c2756d894c37a5fdb38c75cc4067991e71f5c9a6 | |
| parent | dfe5f16a33453b742a66cabc8ea9a52a33279810 (diff) | |
net: lwip: fix get_udev_ipv4_info()
The local variables ipstr, maskstr and gwstr in static function
get_udev_ipv4_info() cannot be pointers to read-only data, since
they may be written to in case the device index is > 0. Therefore
make them char arrays allocated on the stack.
Reported-by: Ilias Apalodimas <[email protected]>
Reported-by: Adriano Cordova <[email protected]>
Link: https://lists.denx.de/pipermail/u-boot/2024-November/572066.html
Signed-off-by: Jerome Forissier <[email protected]>
Reviewed-by: Ilias Apalodimas <[email protected]>
| -rw-r--r-- | net/lwip/net-lwip.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/lwip/net-lwip.c b/net/lwip/net-lwip.c index 470217781a4..b863047f598 100644 --- a/net/lwip/net-lwip.c +++ b/net/lwip/net-lwip.c @@ -91,9 +91,9 @@ struct netif *net_lwip_get_netif(void) static int get_udev_ipv4_info(struct udevice *dev, ip4_addr_t *ip, ip4_addr_t *mask, ip4_addr_t *gw) { - char *ipstr = "ipaddr\0\0"; - char *maskstr = "netmask\0\0"; - char *gwstr = "gatewayip\0\0"; + char ipstr[] = "ipaddr\0\0"; + char maskstr[] = "netmask\0\0"; + char gwstr[] = "gatewayip\0\0"; int idx = dev_seq(dev); char *env; |