diff options
| author | Andrew Goodbody <[email protected]> | 2025-08-07 17:35:19 +0100 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2025-08-29 16:45:19 -0600 |
| commit | 8f90028ccdbfc74487c4b40bd6fe5d34c3309b7a (patch) | |
| tree | b96fdb18f695a4f458f9ada3e431234134b5e351 | |
| parent | 42f959d0b091b779f235d7d0e54a794d4d857917 (diff) | |
power: regulator: lp87565: Cannot test unsigned for being negative
In lp87565_buck_val hex is an unsigned variable being assigned the return
value from a function that returns int. Change hex to be an int so that
the following test for an error as a negative value will work as expected.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <[email protected]>
Reviewed-by: Frieder Schrempf <[email protected]>
| -rw-r--r-- | drivers/power/regulator/lp87565_regulator.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c index 2212cb5c651..ea9c7685e9f 100644 --- a/drivers/power/regulator/lp87565_regulator.c +++ b/drivers/power/regulator/lp87565_regulator.c @@ -82,8 +82,8 @@ static int lp87565_buck_val2volt(int val) static int lp87565_buck_val(struct udevice *dev, int op, int *uV) { - unsigned int hex, adr; - int ret; + unsigned int adr; + int hex, ret; struct dm_regulator_uclass_plat *uc_pdata; uc_pdata = dev_get_uclass_plat(dev); |