diff options
| author | Jerome Forissier <[email protected]> | 2024-11-26 15:45:06 +0100 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2024-11-30 11:52:47 -0600 |
| commit | a37064cb2e482739908e76d6a53914301c8bb8ee (patch) | |
| tree | bfe8f68f4e11ff45a579b66d280cfa27b3ed8099 | |
| parent | 65b38a519b0fcae6a76f48116a5f999400d7294c (diff) | |
net: lwip: wget: fix legacy syntax
Commit 356011f7ac25 ("lwip: fix code style issues") has inadvertently
broken the support for the legacy syntax:
=> wget 192.168.0.16:test.bin
invalid uri, no file path
Invalid URL. Use http(s)://
The reason is two calls to strncpy() were replaced by strlcpy() without
paying attention to the fact that they are not equivalent in the present
case. Since we are using a character counter (n) and since we do not
depend on having a properly null-terminated string at each step in the
parsing, strlcpy() is not justified and strncpy() is the right tool for
the job. So use it again.
Reported-by: Tom Rini <[email protected]>
Signed-off-by: Jerome Forissier <[email protected]>
| -rw-r--r-- | net/lwip/wget.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/lwip/wget.c b/net/lwip/wget.c index 062aa7c44f0..5501ffdd004 100644 --- a/net/lwip/wget.c +++ b/net/lwip/wget.c @@ -161,7 +161,7 @@ static int parse_legacy_arg(char *arg, char *nurl, size_t rem) if (rem < n) return -1; - strlcpy(p, server, n); + strncpy(p, server, n); p += n; rem -= n; if (rem < 1) @@ -172,7 +172,7 @@ static int parse_legacy_arg(char *arg, char *nurl, size_t rem) n = strlen(path); if (rem < n) return -1; - strlcpy(p, path, n); + strncpy(p, path, n); p += n; rem -= n; if (rem < 1) |