diff options
| author | Andrew Goodbody <[email protected]> | 2025-08-07 15:28:58 +0100 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2025-08-29 16:44:46 -0600 |
| commit | aa136393c8fd448e903e3fd3297efb13e54c42d7 (patch) | |
| tree | ef7415177079cdadebdc82fc4ae6cd4c3c14879b | |
| parent | 446b7b8f2d9b5b9bcd473c91f1e45cbb77be6c5f (diff) | |
power: power_i2c: ret is uninitialised if not DM_I2C
In pmic_reg_read ret is only assigned to inside #if
CONFIG_IS_ENABLED(DM_I2C) so move the test and return ret inside as well
and also guard the declaration of ret with CONFIG_IS_ENABLED(DM_I2C) to
prevent a warning about an unused variable.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <[email protected]>
Reviewed-by: Quentin Schulz <[email protected]>
| -rw-r--r-- | drivers/power/power_i2c.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/power/power_i2c.c b/drivers/power/power_i2c.c index c2fc1c6b42f..58289ecce67 100644 --- a/drivers/power/power_i2c.c +++ b/drivers/power/power_i2c.c @@ -75,7 +75,7 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) { unsigned char buf[4] = { 0 }; u32 ret_val = 0; - int ret; + int __maybe_unused ret; if (check_reg(p, reg)) return -EINVAL; @@ -91,9 +91,9 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) return -ENXIO; } ret = dm_i2c_read(dev, reg, buf, pmic_i2c_tx_num); -#endif if (ret) return ret; +#endif switch (pmic_i2c_tx_num) { case 3: |