summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Rini <[email protected]>2015-11-28 08:04:42 -0500
committerYork Sun <[email protected]>2015-12-13 18:27:29 -0800
commitb1f6be5ac8d657e312528ec3c4138c22c54d3f12 (patch)
treead32471fe29274d2c441ec5dd625e7a08acbbf13
parent1a338921642bf622230d91e5eb16b8b5250b44a5 (diff)
qbman_portal.c: Update BUG_ON() call in qbman_swp_mc_submit
With gcc-5.x we get a warning about the ambiguity of BUG_ON(!a != b) and becomes BUG_ON((!a) != b). In this case reading of the function leads to us wanting to rewrite this as BUG_ON(a != b). Cc: Prabhakar Kushwaha <[email protected]> Cc: Geoff Thorpe <[email protected]> Cc: Haiying Wang <[email protected]> Cc: Roy Pledge <[email protected]> Cc: York Sun <[email protected]> Signed-off-by: Tom Rini <[email protected]> Reviewed-by: Bin Meng <[email protected]> Reviewed-by: York Sun <[email protected]>
-rw-r--r--drivers/net/fsl-mc/dpio/qbman_portal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/fsl-mc/dpio/qbman_portal.c b/drivers/net/fsl-mc/dpio/qbman_portal.c
index 5fa8d953e5c..449ff8a8ba3 100644
--- a/drivers/net/fsl-mc/dpio/qbman_portal.c
+++ b/drivers/net/fsl-mc/dpio/qbman_portal.c
@@ -117,7 +117,7 @@ void qbman_swp_mc_submit(struct qbman_swp *p, void *cmd, uint32_t cmd_verb)
{
uint32_t *v = cmd;
#ifdef QBMAN_CHECKING
- BUG_ON(!p->mc.check != swp_mc_can_submit);
+ BUG_ON(p->mc.check != swp_mc_can_submit);
#endif
lwsync();
/* TBD: "|=" is going to hurt performance. Need to move as many fields