diff options
| author | Simon Glass <[email protected]> | 2021-07-06 10:36:40 -0600 |
|---|---|---|
| committer | Simon Glass <[email protected]> | 2021-07-21 10:27:35 -0600 |
| commit | c31d0cb68c1c29f210ab44803f5e5fdcdcfa250b (patch) | |
| tree | fa83c853b072032eb3afa6ac981c6f6449c8008b | |
| parent | 43332d881baa2d66a18e80ec636e0e0da5623c46 (diff) | |
patman: Use bytearray instead of string
If the process outputs a lot of data on stdout this can be quite slow,
since the bytestring is regenerated each time. Use a bytearray instead.
Signed-off-by: Simon Glass <[email protected]>
| -rw-r--r-- | tools/patman/cros_subprocess.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/patman/cros_subprocess.py b/tools/patman/cros_subprocess.py index efd0a5aaf72..fdd51386856 100644 --- a/tools/patman/cros_subprocess.py +++ b/tools/patman/cros_subprocess.py @@ -169,11 +169,11 @@ class Popen(subprocess.Popen): self.stdin.close() if self.stdout: read_set.append(self.stdout) - stdout = b'' + stdout = bytearray() if self.stderr and self.stderr != self.stdout: read_set.append(self.stderr) - stderr = b'' - combined = b'' + stderr = bytearray() + combined = bytearray() input_offset = 0 while read_set or write_set: |
