diff options
| author | Quentin Schulz <[email protected]> | 2026-01-08 13:28:36 +0100 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2026-01-16 09:53:57 -0600 |
| commit | cb1d775d253c84a0eee0db94d8bf4145d9fd7bd3 (patch) | |
| tree | adcd7878c8b2f8852cc10f23046126b8e677b630 | |
| parent | dc82599c45b31b84fcbd0e9c0bf2dcf73f004391 (diff) | |
spl: fix incorrect dependency for SPL_NET
When SPL_NET is included, scripts/Makefile.xpl includes net/. However,
in this directory, the Makefile only compiles things if CONFIG_NET or
CONFIG_NET_LWIP is defined (it doesn't use $(PHASE_)). Therefore, at
least one networking stack needs to be enabled for SPL_NET=y to do
anything meaningful.
In certain cases (e.g. am62px_evm_r5_ethboot_defconfig + NO_NET=y via
menuconfig), it is possible to fail the build with undefined references
(since include/net-common.h does check with CONFIG_IS_ENABLED(NET) which
would be true for SPL_NET, but the implementation wouldn't be compiled).
Fix this oversight by making sure a network stack (and the legacy one)
is available when selecting SPL_NET.
Fixes: 8cb330355bd5 ("net: introduce alternative implementation as net/lwip/")
Reviewed-by: Jerome Forissier <[email protected]>
Signed-off-by: Quentin Schulz <[email protected]>
| -rw-r--r-- | common/spl/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 4f4119f5806..c7db88345b4 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -1153,7 +1153,7 @@ config SPL_DM_SPI_FLASH config SPL_NET bool "Support networking" - depends on !NET_LWIP + depends on NET select SPL_USE_TINY_PRINTF_POINTER_SUPPORT if SPL_USE_TINY_PRINTF help Enable support for network devices (such as Ethernet) in SPL. |