diff options
| author | Álvaro Fernández Rojas <[email protected]> | 2023-02-11 16:29:09 +0100 |
|---|---|---|
| committer | Dario Binacchi <[email protected]> | 2023-02-27 16:30:05 +0100 |
| commit | d346971559297900f0cd27665be8d9b877c156fe (patch) | |
| tree | e807a0a3dc12d6e03c3f3410cbc48e2770ef8444 | |
| parent | 31b273186355e8da27967ab519a65965d440cb32 (diff) | |
mtd: rawnand: brcmnand: fix OOB R/W with Hamming ECC
Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall
always be done without ECC enabled.
This is a problem when adding JFFS2 cleanmarkers to erased blocks. If JFFS2
clenmarkers are added to the OOB with ECC enabled, OOB bytes will be changed
from ff ff ff to 00 00 00, reporting incorrect ECC errors.
Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Brian Norris <[email protected]>
Signed-off-by: Miquel Raynal <[email protected]>
Link: https://lore.kernel.org/linux-mtd/[email protected]
[Ported to U-Boot from the Linux kernel]
Signed-off-by: Linus Walleij <[email protected]>
Acked-by: William Zhang <[email protected]>
Signed-off-by: Dario Binacchi <[email protected]>
| -rw-r--r-- | drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index b2ebcaf7a5b..efbf9a3120a 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -2515,6 +2515,12 @@ static int brcmnand_init_cs(struct brcmnand_host *host, ofnode dn) ret = nand_register(0, mtd); #endif /* __UBOOT__ */ + /* If OOB is written with ECC enabled it will cause ECC errors */ + if (is_hamming_ecc(host->ctrl, &host->hwcfg)) { + chip->ecc.write_oob = brcmnand_write_oob_raw; + chip->ecc.read_oob = brcmnand_read_oob_raw; + } + return ret; } |