summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorConor Dooley <[email protected]>2024-05-15 16:04:30 +0100
committerLeo Yu-Chi Liang <[email protected]>2024-05-30 16:00:52 +0800
commitd4573c05cbea34f8d7c3c2d5e49b7b057b895882 (patch)
tree127b2858abafd8549b9dd677ae8204b310473e35
parent46ff00bea5dd2dd247d5e2fdadbf5dcf8653cd9a (diff)
board: microchip: icicle: correct type for node offset
Node offsets returned by libfdt can contain negative error numbers, so the variable type should be "int". As things stand, if the ethernet nodes are not found in the early init callback, the if (node < 0) tests pass and the code errors out while trying to set the local-mac-address for a non-existent node. Fixes: 64413e1b7c ("riscv: Add Microchip MPFS Icicle Kit support") Signed-off-by: Conor Dooley <[email protected]> Reviewed-by: Leo Yu-Chi Liang <[email protected]>
-rw-r--r--board/microchip/mpfs_icicle/mpfs_icicle.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/board/microchip/mpfs_icicle/mpfs_icicle.c b/board/microchip/mpfs_icicle/mpfs_icicle.c
index 0f5f82924e7..844937951c0 100644
--- a/board/microchip/mpfs_icicle/mpfs_icicle.c
+++ b/board/microchip/mpfs_icicle/mpfs_icicle.c
@@ -73,7 +73,7 @@ int board_early_init_f(void)
int board_late_init(void)
{
u32 ret;
- u32 node;
+ int node;
u8 idx;
u8 device_serial_number[16] = { 0 };
unsigned char mac_addr[6];