diff options
| author | Masahiro Yamada <[email protected]> | 2014-08-25 12:39:45 +0900 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2014-08-28 17:18:48 -0400 |
| commit | d6538d22de83110369752682cc3e3d3860e09d91 (patch) | |
| tree | 4eef15470c5350860ecf25768400148f685dfea0 | |
| parent | 13246f48610757d1e5d7f4d92f35378e749235ec (diff) | |
tools/genboardscfg.py: wait for unfinished subprocesses before error-out
When an error occurs or the program is terminated by the user
on the way, the destructer __del__ of class Slot is invoked and
the work directories are removed.
We have to make sure there are no subprocesses (in this case,
"make O=<work_dir> ...") using the work directories before
removing them. Otherwise the subprocess spits a bunch of error
messages possibly causing more problems. Perhaps some users
may get upset to see too many error messages.
Signed-off-by: Masahiro Yamada <[email protected]>
Acked-by: Simon Glass <[email protected]>
| -rwxr-xr-x | tools/genboardscfg.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index 1406acd46f8..a0df7058b15 100755 --- a/tools/genboardscfg.py +++ b/tools/genboardscfg.py @@ -276,6 +276,9 @@ class Slot: def __del__(self): """Delete the working directory""" + if not self.occupied: + while self.ps.poll() == None: + pass shutil.rmtree(self.build_dir) def add(self, defconfig): |