diff options
| author | Simon Glass <[email protected]> | 2024-12-07 10:24:02 -0700 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2024-12-12 16:35:24 -0600 |
| commit | e931f589257afa78d621dd7d360e0e7a25f2d47f (patch) | |
| tree | 2125e1468f2cab78b4814c6145c22d098ef12a3a | |
| parent | bf86a3e830fca2884b3d4a5ef91bc60ba24d06dd (diff) | |
spl: Report a loader failure
If a loader returns an error code it is silently ignored. Show a message
to at least provide some feedback to the user.
Signed-off-by: Simon Glass <[email protected]>
| -rw-r--r-- | common/spl/spl.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/common/spl/spl.c b/common/spl/spl.c index 1ceb63daf31..7c57eb8539b 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -612,6 +612,7 @@ static int boot_from_devices(struct spl_image_info *spl_image, for (i = 0; i < count && spl_boot_list[i] != BOOT_DEVICE_NONE; i++) { struct spl_image_loader *loader; int bootdev = spl_boot_list[i]; + int ret; if (CONFIG_IS_ENABLED(SHOW_ERRORS)) ret = -ENXIO; @@ -631,10 +632,13 @@ static int boot_from_devices(struct spl_image_info *spl_image, "Unsupported Boot Device!\n"); } } - if (loader && - !spl_load_image(spl_image, loader)) { - spl_image->boot_device = bootdev; - return 0; + if (loader) { + ret = spl_load_image(spl_image, loader); + if (!ret) { + spl_image->boot_device = bootdev; + return 0; + } + printf("Error: %d\n", ret); } } } |