diff options
| author | Fabio Estevam <[email protected]> | 2024-03-12 21:36:41 -0300 |
|---|---|---|
| committer | Fabio Estevam <[email protected]> | 2024-03-17 17:59:32 -0300 |
| commit | fdd529fa624e8b235a949b63b932d3eb1e9641b9 (patch) | |
| tree | 1763935057f6646f0bedcfa00c81e762c509bf7a | |
| parent | e1897784aa9e8dec30ad1067c1107dbd287e5024 (diff) | |
colibri-imx8x: Fix sc_misc_otp_fuse_read() error check
Commit aa6e698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage")
made an incorrect logic change in the error code check of
sc_misc_otp_fuse_read():
- if (sc_err == SC_ERR_NONE) {
+ if (sc_err) {
/* DX has two A35 cores disabled */
return (val & 0xf) != 0x0;
}
The other changes in this commit are correct.
sc_misc_otp_fuse_read() returns 0 on a successful fuse read.
This inversion causes board_mem_get_layout() to report incorrect RAM size.
Go back the original error check logic to fix the problem.
Fixes: aa6e698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage")
Reported-by: Hiago De Franco <[email protected]>
Signed-off-by: Fabio Estevam <[email protected]>
Reviewed-by: Peng Fan <[email protected]>
Acked-by: Marcel Ziswiler <[email protected]>
Tested-by: Hiago De Franco <[email protected]> # Toradex Colibri iMX8X 1GB
| -rw-r--r-- | board/toradex/colibri-imx8x/colibri-imx8x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/toradex/colibri-imx8x/colibri-imx8x.c b/board/toradex/colibri-imx8x/colibri-imx8x.c index 2c673a4a6b0..6fc8076163c 100644 --- a/board/toradex/colibri-imx8x/colibri-imx8x.c +++ b/board/toradex/colibri-imx8x/colibri-imx8x.c @@ -46,7 +46,7 @@ static int is_imx8dx(void) u32 val = 0; int sc_err = sc_misc_otp_fuse_read(-1, 6, &val); - if (sc_err) { + if (!sc_err) { /* DX has two A35 cores disabled */ return (val & 0xf) != 0x0; } |
