diff options
| author | Tom Rini <[email protected]> | 2024-10-11 12:23:25 -0600 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2024-10-11 12:23:25 -0600 |
| commit | 47e544f576699ca4630e20448db6a05178960697 (patch) | |
| tree | f31951120512ac41f145dc0fcf6b0bbdfe5b9c01 /board/sunxi | |
| parent | 5d899fc58c44fe5623e31524da2205d8597a53d1 (diff) | |
| parent | 0220a68c25cbfdfa495927f83abf0b1d4ebd823b (diff) | |
Merge patch series "Tidy up use of 'SPL' and CONFIG_SPL_BUILD"
Simon Glass <[email protected]> says:
When the SPL build-phase was first created it was designed to solve a
particular problem (the need to init SDRAM so that U-Boot proper could
be loaded). It has since expanded to become an important part of U-Boot,
with three phases now present: TPL, VPL and SPL
Due to this history, the term 'SPL' is used to mean both a particular
phase (the one before U-Boot proper) and all the non-proper phases.
This has become confusing.
For a similar reason CONFIG_SPL_BUILD is set to 'y' for all 'SPL'
phases, not just SPL. So code which can only be compiled for actual SPL,
for example, must use something like this:
#if defined(CONFIG_SPL_BUILD) && !defined(CONFIG_TPL_BUILD)
In Makefiles we have similar issues. SPL_ has been used as a variable
which expands to either SPL_ or nothing, to chose between options like
CONFIG_BLK and CONFIG_SPL_BLK. When TPL appeared, a new SPL_TPL variable
was created which expanded to 'SPL_', 'TPL_' or nothing. Later it was
updated to support 'VPL_' as well.
This series starts a change in terminology and usage to resolve the
above issues:
- The word 'xPL' is used instead of 'SPL' to mean a non-proper build
- A new CONFIG_XPL_BUILD define indicates that the current build is an
'xPL' build
- The existing CONFIG_SPL_BUILD is changed to mean SPL; it is not now
defined for TPL and VPL phases
- The existing SPL_ Makefile variable is renamed to SPL_
- The existing SPL_TPL Makefile variable is renamed to PHASE_
It should be noted that xpl_phase() can generally be used instead of
the above CONFIGs without a code-space or run-time penalty.
This series does not attempt to convert all of U-Boot to use this new
terminology but it makes a start. In particular, renaming spl.h and
common/spl seems like a bridge too far at this point.
The series is fully bisectable. It has also been checked to ensure there
are no code-size changes on any commit.
Diffstat (limited to 'board/sunxi')
| -rw-r--r-- | board/sunxi/board.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 961cdcde74d..824c322a0dc 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -281,7 +281,7 @@ int dram_init(void) return 0; } -#if defined(CONFIG_NAND_SUNXI) && defined(CONFIG_SPL_BUILD) +#if defined(CONFIG_NAND_SUNXI) && defined(CONFIG_XPL_BUILD) static void nand_pinmux_setup(void) { unsigned int pin; @@ -530,7 +530,7 @@ int mmc_get_env_dev(void) #endif #endif /* CONFIG_MMC */ -#ifdef CONFIG_SPL_BUILD +#ifdef CONFIG_XPL_BUILD static void sunxi_spl_store_dram_size(phys_addr_t dram_size) { @@ -641,7 +641,7 @@ void sunxi_board_init(void) else printf("Failed to set core voltage! Can't set CPU frequency\n"); } -#endif /* CONFIG_SPL_BUILD */ +#endif /* CONFIG_XPL_BUILD */ #ifdef CONFIG_USB_GADGET int g_dnl_board_usb_cable_connected(void) |
