summaryrefslogtreecommitdiff
path: root/boot
diff options
context:
space:
mode:
authorTom Rini <[email protected]>2022-08-27 08:07:09 -0400
committerTom Rini <[email protected]>2022-08-27 08:07:09 -0400
commit1573b6a86993fcf80d4badc866a46b78df7e6bda (patch)
treed56567f58fac5b9cd1578df9e0bd5a8982a27235 /boot
parentcd3872ce7e5bf90424a10eda0fe405d04e82adb9 (diff)
parentc2ee5ee7b3393770dbe809ca36814083feffaf83 (diff)
Merge tag 'dm-pull-26aug22' of https://source.denx.de/u-boot/custodians/u-boot-dm
binman/patman documentation improvements other minor fixes
Diffstat (limited to 'boot')
-rw-r--r--boot/bootmeth_distro.c6
-rw-r--r--boot/bootmeth_pxe.c6
-rw-r--r--boot/vbe.c2
-rw-r--r--boot/vbe_simple.c7
4 files changed, 10 insertions, 11 deletions
diff --git a/boot/bootmeth_distro.c b/boot/bootmeth_distro.c
index fea09b2c2fb..5c6c687f0a6 100644
--- a/boot/bootmeth_distro.c
+++ b/boot/bootmeth_distro.c
@@ -35,8 +35,8 @@ static int distro_get_state_desc(struct udevice *dev, char *buf, int maxsize)
return 0;
}
-static int disto_getfile(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *sizep)
+static int distro_getfile(struct pxe_context *ctx, const char *file_path,
+ char *file_addr, ulong *sizep)
{
struct distro_info *info = ctx->userdata;
ulong addr;
@@ -113,7 +113,7 @@ static int distro_boot(struct udevice *dev, struct bootflow *bflow)
addr = map_to_sysmem(bflow->buf);
info.dev = dev;
info.bflow = bflow;
- ret = pxe_setup_ctx(&ctx, &cmdtp, disto_getfile, &info, true,
+ ret = pxe_setup_ctx(&ctx, &cmdtp, distro_getfile, &info, true,
bflow->subdir);
if (ret)
return log_msg_ret("ctx", -EINVAL);
diff --git a/boot/bootmeth_pxe.c b/boot/bootmeth_pxe.c
index f1e2b4c7762..e6992168c06 100644
--- a/boot/bootmeth_pxe.c
+++ b/boot/bootmeth_pxe.c
@@ -23,8 +23,8 @@
#include <net.h>
#include <pxe_utils.h>
-static int disto_pxe_getfile(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *sizep)
+static int distro_pxe_getfile(struct pxe_context *ctx, const char *file_path,
+ char *file_addr, ulong *sizep)
{
struct distro_info *info = ctx->userdata;
ulong addr;
@@ -142,7 +142,7 @@ static int distro_pxe_boot(struct udevice *dev, struct bootflow *bflow)
info.dev = dev;
info.bflow = bflow;
info.cmdtp = &cmdtp;
- ret = pxe_setup_ctx(ctx, &cmdtp, disto_pxe_getfile, &info, false,
+ ret = pxe_setup_ctx(ctx, &cmdtp, distro_pxe_getfile, &info, false,
bflow->subdir);
if (ret)
return log_msg_ret("ctx", -EINVAL);
diff --git a/boot/vbe.c b/boot/vbe.c
index e6ee087dc24..52b32830037 100644
--- a/boot/vbe.c
+++ b/boot/vbe.c
@@ -40,7 +40,7 @@ int vbe_find_next_device(struct udevice **devp)
int vbe_find_first_device(struct udevice **devp)
{
uclass_find_first_device(UCLASS_BOOTMETH, devp);
- if (*devp && is_vbe(*devp))
+ if (!*devp || is_vbe(*devp))
return 0;
return vbe_find_next_device(devp);
diff --git a/boot/vbe_simple.c b/boot/vbe_simple.c
index a395bc20a60..0fc57388f35 100644
--- a/boot/vbe_simple.c
+++ b/boot/vbe_simple.c
@@ -225,17 +225,16 @@ static int bootmeth_vbe_simple_ft_fixup(void *ctx, struct event *event)
{
oftree tree = event->data.ft_fixup.tree;
struct udevice *dev;
- ofnode node;
- int ret;
/*
* Ideally we would have driver model support for fixups, but that does
* not exist yet. It is a step too far to try to do this before VBE is
* in place.
*/
- for (ret = vbe_find_first_device(&dev); dev;
- ret = vbe_find_next_device(&dev)) {
+ for (vbe_find_first_device(&dev); dev; vbe_find_next_device(&dev)) {
struct simple_state state;
+ ofnode node;
+ int ret;
if (strcmp("vbe_simple", dev->driver->name))
continue;