diff options
| author | Siddharth Vadapalli <[email protected]> | 2026-03-05 16:08:14 +0530 |
|---|---|---|
| committer | Mattijs Korpershoek <[email protected]> | 2026-03-12 09:59:33 +0100 |
| commit | 433a17aca15481cde866a9bc636b61584360fbb3 (patch) | |
| tree | 99ff04b308f7740afe706cbc0390f735812a4758 /common | |
| parent | 7b60cd933bc1db31c94483f6aeb9289722427c5e (diff) | |
common: spl: spl_dfu.c: Fix warning associated with PCI subclass_code
The subclass_code member of the pci_ep_header structure is a 1-byte
field. The macro PCI_CLASS_MEMORY_RAM is a concetation of baseclass_code
and subclass_code as follows:
PCI_BASE_CLASS_MEMORY: 0x05
Subclass Code for RAM: 0x00
PCI_CLASS_MEMORY_RAM: 0x0500
Hence, instead of extracting it via an implicity type conversion from int
to u8 which throws a warning, explicitly mask the bits to extract the
subclass_code.
Fixes: cde77583cf0b ("spl: Add support for Device Firmware Upgrade (DFU) over PCIe")
Signed-off-by: Siddharth Vadapalli <[email protected]>
Tested-by: Anshul Dalal <[email protected]>
Reviewed-by: Mattijs Korpershoek <[email protected]>
Tested-by: Mattijs Korpershoek <[email protected]> # am62x_evm_a53
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mattijs Korpershoek <[email protected]>
Diffstat (limited to 'common')
| -rw-r--r-- | common/spl/spl_dfu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/spl/spl_dfu.c b/common/spl/spl_dfu.c index b09f82790c9..7d21bb4d16a 100644 --- a/common/spl/spl_dfu.c +++ b/common/spl/spl_dfu.c @@ -64,7 +64,7 @@ static int dfu_over_pcie(void) hdr.deviceid = CONFIG_SPL_PCI_DFU_DEVICE_ID; hdr.vendorid = CONFIG_SPL_PCI_DFU_VENDOR_ID; hdr.baseclass_code = PCI_BASE_CLASS_MEMORY; - hdr.subclass_code = PCI_CLASS_MEMORY_RAM; + hdr.subclass_code = PCI_CLASS_MEMORY_RAM & 0xff; ret = pci_ep_write_header(dev, fn, &hdr); if (ret) { |