summaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
authorAndre Przywara <[email protected]>2025-03-25 17:47:44 +0000
committerTom Rini <[email protected]>2025-04-10 16:16:39 -0600
commit82f5ce11e669d86ac08e6ba800d4a97ad734665b (patch)
tree1772ab4f35baacb3714a80e202a7fa166bb15e11 /common
parentcb7555e93075114fe4af0adb806877ac4d4ef80d (diff)
common: console: move break; statement
In console_setfile(), there is some #ifdef'ed code, updating monitor functions for a U-Boot proper build. This is called inside a switch/case statement, but the closing "break;" is inside the #ifdef section. This doesn't look right: we should not fall through to the error case for an SPL/TPL build. Move the "break" to be always effective, solving a compiler warning about an untagged implicit fallthrough. Signed-off-by: Andre Przywara <[email protected]> Reviewed-by: Tom Rini <[email protected]>
Diffstat (limited to 'common')
-rw-r--r--common/console.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/console.c b/common/console.c
index b69bb189639..275da2f264d 100644
--- a/common/console.c
+++ b/common/console.c
@@ -208,8 +208,8 @@ static int console_setfile(int file, struct stdio_dev * dev)
gd->jt->printf = printf;
break;
}
- break;
#endif
+ break;
default: /* Invalid file ID */
error = -1;
}