summaryrefslogtreecommitdiff
path: root/doc/develop/bootstd/script.rst
diff options
context:
space:
mode:
authorSam Protsenko <[email protected]>2025-10-25 20:06:54 -0500
committerPeng Fan <[email protected]>2025-11-07 09:28:28 +0800
commit20b19639cdf86f4fb1289443bc47866a8047b619 (patch)
treef91e54fecff639a7e95b40c24af4443b29393204 /doc/develop/bootstd/script.rst
parentf391a1158f3db496ce994b613f76b389ef275552 (diff)
mmc: dw_mmc: Do not export dwmci_send_cmd() and dwmci_set_ios()
Do not over-expose the private dw_mmc API. The glue layer drivers at this point shouldn't be aware and shouldn't use the generic dwmci_send_cmd() and dwmci_set_ios() functions. Making those functions public causes a "leaky abstraction" issue. It clutters the public interface of generic dw_mmc driver and possibly leads to improper usage of those functions, so it's a bad design. If struct dm_dwmci_ops has to be extended, do so by copying it first (like it's done for example in snps_dw_mmc driver). That also makes sure the future changes to struct dm_dwmci_ops in dw_mmc driver will be automatically reflected in all extended copies, and avoid code duplication. This effectively reverts commit ef3b16bb8e73 ("mmc: dw_mmc: export dwmci_send_cmd() and dwmci_set_ios()"). No functional change. Fixes: ef3b16bb8e73 ("mmc: dw_mmc: export dwmci_send_cmd() and dwmci_set_ios()") Signed-off-by: Sam Protsenko <[email protected]> Reviewed-by: Anand Moon <[email protected]> Signed-off-by: Peng Fan <[email protected]>
Diffstat (limited to 'doc/develop/bootstd/script.rst')
0 files changed, 0 insertions, 0 deletions