diff options
| author | Jasper Orschulko <[email protected]> | 2024-05-10 13:38:34 +0200 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2025-10-21 13:18:46 -0600 |
| commit | 813a0df27a8af587bd25a6a4719f68066b370091 (patch) | |
| tree | 1eeeabfac84d9b92d0b2cc1e062f887dcd540dee /doc/develop/bootstd | |
| parent | 0f865ab5d68484b4dc1724809de1be06edc85df1 (diff) | |
env: Invert gd->env_valid for env_mmc_save
The A/B update strategy of the env's has a gap in the first 2 calls of saveenv.
The env's are stored twice on the first memory area if:
gd->env_valid == ENV_INVALID.
u-boot=> saveenv
Saving Environment to MMC... Writing to MMC(1)... OK
u-boot=> saveenv
Saving Environment to MMC... Writing to MMC(1)... OK <-- !!!
u-boot=> saveenv
Saving Environment to MMC... Writing to redundant MMC(1)... OK
u-boot=> saveenv
Saving Environment to MMC... Writing to MMC(1)... OK
This is the same issue as resolved in commit e589d5822cac ("env: spi:
Fix gd->env_valid for the first write")
Signed-off-by: Michael Glembotzki <[email protected]>
Signed-off-by: Jasper Orschulko <[email protected]>
Signed-off-by: Michael Heimpold <[email protected]>
[trini: Amend the commit message]
---
Changes in v2:
- Rebase to current master
- Amend the commit message to reference the SPI version of this fix,
which had significant follow-up discussion.
Diffstat (limited to 'doc/develop/bootstd')
0 files changed, 0 insertions, 0 deletions