summaryrefslogtreecommitdiff
path: root/doc/develop/python_cq.rst
diff options
context:
space:
mode:
authorSam Day <[email protected]>2025-01-22 10:26:59 +0000
committerCaleb Connolly <[email protected]>2025-01-22 16:45:02 +0100
commit782641f872a4d58e388b8ea020a8e71bc966a348 (patch)
treec8d0a88ab1bd9af0cc2d0fd22383ba99936d5604 /doc/develop/python_cq.rst
parent3db33a6fd69078c5b77b32fe7eaede4ec08a9471 (diff)
mach-snapdragon: pass fdt to qcom_parse_memory
commit fc37a73e6679 ("fdt: Swap the signature for board_fdt_blob_setup()") introduced a subtle change to the Snapdragon implementation, removing the assignment to gd->fdt_blob partway through the function. This breaks qcom_parse_memory() which was also called during board_fdt_blob_setup(). The underlying issue here is that qcom_parse_memory is using the of_ api to traverse a devicetree, which relies on the fdt_blob in global data. Rather than relying on this subtle behaviour, explicitly pass the FDT that should be consulted for a /memory node. Using the OF API is typically preferable because it's easier to read, but using the lower level fdt_ methods instead here doesn't add too much complexity, I think. Finally, a minor tweak was made to board_fdt_blob_setup to use the passed fdt blob pointer instead of gd->fdt_blob, which removes the last of the references to global data in this area. Fixes: fc37a73e6679 (fdt: Swap the signature for board_fdt_blob_setup()) Reviewed-by: Caleb Connolly <[email protected]> Signed-off-by: Sam Day <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Caleb Connolly <[email protected]>
Diffstat (limited to 'doc/develop/python_cq.rst')
0 files changed, 0 insertions, 0 deletions