summaryrefslogtreecommitdiff
path: root/doc/develop
diff options
context:
space:
mode:
authorMarek Vasut <[email protected]>2021-11-13 03:23:11 +0100
committerRamon Fried <[email protected]>2021-12-02 08:35:37 +0200
commit8777033722719a37eac8d07efa3e4b3a665612e1 (patch)
treed8a6754950a9dffe875484e66324c1ac0d6ebe4a /doc/develop
parent4a14bfffd42f968ed9d72a780a8d44a9053c5b95 (diff)
net: eth-phy: Handle gpio_request_by_name() return value
The gpio_request_by_name() returns zero in case of success, however the conditional return value check in gpio_request_by_name() checks only for (ret != -ENOENT) and if the condition is true, returns ret outright. This leads to a situation where successful gpio_request_by_name() return leads to immediate successful eth_phy_of_to_plat() return as well, and to skipped parsing of "reset-assert-us" and "reset-deassert-us", so the PHY driver operates with valid reset GPIO, but with assert/deassert times set to default, which is 0, instead of the values from DT. This breaks PHY reset. Fix this by checking if return value is non-zero and then for this one single allowed non-zero return value, -ENOENT. Signed-off-by: Marek Vasut <[email protected]> Cc: Ramon Fried <[email protected]> Reviewed-by: Ramon Fried <[email protected]>
Diffstat (limited to 'doc/develop')
0 files changed, 0 insertions, 0 deletions