diff options
| author | Vladimir Oltean <[email protected]> | 2020-05-07 00:11:52 +0200 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2020-05-07 11:05:00 -0400 |
| commit | 4d4e4cf7798276bcb047b65cf80fde63fd347903 (patch) | |
| tree | f12fdfb7245ee816c55f69124e04a261ee3e9578 /drivers/net | |
| parent | 13114f38e2ccea9386726d8b9831dfc310589548 (diff) | |
phy: atheros: Clarify the intention of ar8021_config
Debug register 5 contains TX_CLK DELAY at bit 8 and reserved values at
the other bit positions, just like the other PHYs in the family do.
Therefore, it is not necessary to hardcode the reserved values, but
instead simply follow the read-modify-write procedure from the common
function.
Signed-off-by: Vladimir Oltean <[email protected]>
Acked-by: Joe Hershberger <[email protected]>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/phy/atheros.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 3e59c3f3915..3cc162828ca 100644 --- a/drivers/net/phy/atheros.c +++ b/drivers/net/phy/atheros.c @@ -56,10 +56,10 @@ static void ar803x_enable_tx_delay(struct phy_device *phydev, bool on) static int ar8021_config(struct phy_device *phydev) { - phy_write(phydev, MDIO_DEVAD_NONE, 0x00, 0x1200); - phy_write(phydev, MDIO_DEVAD_NONE, AR803x_PHY_DEBUG_ADDR_REG, - AR803x_DEBUG_REG_5); - phy_write(phydev, MDIO_DEVAD_NONE, AR803x_PHY_DEBUG_DATA_REG, 0x3D47); + phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, + BMCR_ANENABLE | BMCR_ANRESTART); + + ar803x_enable_tx_delay(phydev, true); phydev->supported = phydev->drv->features; return 0; |